Add an embedder test for inserted text not saving correctly [pdfium : main]
0 views
Skip to first unread message
Andy Phan (Gerrit)
Mar 13, 2026, 1:00:57 PM (4 days ago) Mar 13
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Andy Phan voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Mar 13, 2026, 1:46:42 PM (4 days ago) Mar 13
to Lei Zhang, Andy Phan, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Mar 13, 2026, 1:47:25 PM (4 days ago) Mar 13
to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add an embedder test for inserted text not saving correctly
Add a test to show the editing steps to add text to a particular page
renders correctly in memory, but the text is missing when saved. Thanks
to prior investigations on the bug, there was already some embedder test
code and the problematic portion of the sample PDF has already been
identified.
Bug: 461845674
Change-Id: Ib3a7ecf913d0c6693e5f28bc25e8a8a33d4b88a8
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Andy Phan <andy...@chromium.org>
Files:
- M fpdfsdk/fpdf_edit_embeddertest.cpp
- A testing/resources/bug_461845674.in
- A testing/resources/bug_461845674.pdf
- A testing/resources/embedder_tests/bug_461845674_agg.png
- A testing/resources/embedder_tests/bug_461845674_agg_mac.png
- A testing/resources/embedder_tests/bug_461845674_skia.png
- A testing/resources/embedder_tests/bug_461845674_skia_mac.png
- A testing/resources/embedder_tests/bug_461845674_skia_win.png
Change size: M
Delta: 8 files changed, 105 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andy Phan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages