Move and use MaybeRemoveSubsettedFontPrefix() [pdfium : main]
0 views
Skip to first unread message
Andy Phan (Gerrit)
Feb 20, 2026, 7:38:27 PM (2 days ago) Feb 20
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Andy Phan added 1 comment![]( "Open in Gerrit")
File core/fxge/cfx_font_util.h
Line 12, Patchset 1:
namespace fxge {Andy Phan . resolved
Not sure what convention we want here for util functions. I chose fxge namespace. I saw some other util files using a class instead.
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Feb 20, 2026, 7:44:26 PM (2 days ago) Feb 20
to Andy Phan, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Andy Phan
Lei Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Lei Zhang . resolved
WDYT about moving to core/fxge/fx_font.h instead?
Related details
Attention is currently required from:
- Andy Phan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Feb 20, 2026, 7:46:44 PM (2 days ago) Feb 20
to Andy Phan, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Andy Phan
Lei Zhang added 1 comment![]( "Open in Gerrit")
File core/fpdfapi/font/cpdf_simplefont.cpp
Line 248, Patchset 2 (Parent):
if (base_font_name_.GetLength() > 7 && base_font_name_[6] == '+') {Lei Zhang . resolved
It's also different because it expects the name to be at least "??????+?", while MaybeRemoveSubsettedFontPrefix() is trying to match "XXXXXX+".
Related details
Attention is currently required from:
- Andy Phan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Feb 20, 2026, 7:47:32 PM (2 days ago) Feb 20
to Andy Phan, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Andy Phan
Lei Zhang added 1 comment![]( "Open in Gerrit")
Commit Message
Line 7, Patchset 2 (Latest):
Move and use MaybeRemoveSubsettedFontPrefix()Lei Zhang . unresolved
"reuse"
Related details
Attention is currently required from:
- Andy Phan
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages