Fold CFX_DIBitmap::ConvertBGRColorScale() into ConvertColorScale() [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
May 8, 2026, 4:00:47 PM (5 days ago) May 8
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
May 8, 2026, 4:34:16 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 8, 2026, 4:36:22 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fold CFX_DIBitmap::ConvertBGRColorScale() into ConvertColorScale()
Since ConvertColorScale() is very short and its the only caller to
ConvertBGRColorScale(), just combine them.
Change-Id: Ib12cf2478c2534f13ac8c32410e31b9ce85c268a
Reviewed-by: Tom Sepez <tse...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Files:
- M core/fxge/dib/cfx_dibitmap.cpp
- M core/fxge/dib/cfx_dibitmap.h
Change size: S
Delta: 2 files changed, 5 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tom Sepez
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages