Rename FX_Random_MT_GenerateMT() [pdfium : main]
0 views
Skip to first unread message
Andy Phan (Gerrit)
Feb 19, 2026, 7:22:29 PM (3 days ago) Feb 19
to Pdfium LUCI CQ, pdfium-...@googlegroups.com
Andy Phan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Andy Phan . resolved
The function changes again in the next CL. This is just to make the review for the next CL a little easier, hopefully.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Feb 19, 2026, 7:35:08 PM (3 days ago) Feb 19
to Andy Phan, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Andy Phan
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
File core/fxcrt/fx_random.cpp
Line 131, Patchset 1 (Latest):
for (size_t i = 0; i < buffer.size(); ++i) {Lei Zhang . unresolved
Can also do range-based for-loop here to further modernize this code.
Related details
Attention is currently required from:
- Andy Phan
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andy Phan (Gerrit)
Feb 19, 2026, 7:42:53 PM (3 days ago) Feb 19
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Andy Phan added 1 comment![]( "Open in Gerrit")
File core/fxcrt/fx_random.cpp
Can also do range-based for-loop here to further modernize this code.
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Feb 20, 2026, 5:23:36 PM (2 days ago) Feb 20
to Andy Phan, Lei Zhang, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: core/fxcrt/fx_random.cpp
Insertions: 2, Deletions: 2.
@@ -128,8 +128,8 @@
void FX_Random_MT_Fill(pdfium::span<uint32_t> buffer) {
void* context = ContextFromNextGlobalSeed();
- for (size_t i = 0; i < buffer.size(); ++i) {
- buffer[i] = FX_Random_MT_Generate(context);
+ for (uint32_t& val : buffer) {
+ val = FX_Random_MT_Generate(context);
}
FX_Random_MT_Close(context);
}
```
Change information
Commit message:
Rename FX_Random_MT_GenerateMT()
FX_Random_MT_Generate() and FX_Random_GenerateMT() have really similar
names, but one returns a random number and one fills a passed-in buffer
with random numbers. Make the latter more distinguishable by renaming it
to FX_Random_MT_Fill().
Then, modernize the function by using modern naming style and a
range-based for loop.
Change-Id: I92e11809eae2f051b9fc741b85277c50b5322f71
Commit-Queue: Andy Phan <andy...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Files:
- M core/fpdfapi/parser/cpdf_security_handler.cpp
- M core/fxcrt/fx_random.cpp
- M core/fxcrt/fx_random.h
- M core/fxcrt/fx_random_unittest.cpp
- M fxjs/xfa/cfxjse_formcalc_context.cpp
Change size: S
Delta: 5 files changed, 9 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages