Replace FWL_STATE defines with WidgetState enum and Mask [pdfium : main]

0 views

Skip to first unread message

Aryan Krishnan (Gerrit)

unread,

May 31, 2026, 1:56:28 PM (4 days ago) May 31

to Helmut Januschka, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Attention needed from Helmut Januschka

Aryan Krishnan added 2 comments

Commit Message

Line 9, Patchset 1 (Latest):

Companion to the FWL_STYLE_WGT -> WidgetStyle Mask conversion. Convert the FWL widget state bits into a scoped WidgetState enum and store CFWL_Widget::Properties::states_ as Mask<WidgetState>.

Aryan Krishnan . unresolved

Wrap lines 9, 11, 13

File xfa/fwl/cfwl_datetimepicker.cpp

Line 29, Patchset 1 (Latest): Properties{{}, FWL_STYLEEXT_DTP_ShortDateFormat, {}},

Aryan Krishnan . unresolved

public:
    uint32_t styles_ = FWL_STYLE_WGT_Child;  // Mask of FWL_STYLE_*_*.
    uint32_t style_exts_ = 0;                // Mask of FWL_STYLEEXT_*_*.
    Mask<WidgetState> states_;

Shouldn't the first argument also be 0?
Although I do remember another CL did change the type of styles_.

Open in Gerrit

Related details

Attention is currently required from:

Helmut Januschka

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages