Move and reuse MaybeRemoveSubsettedFontPrefix() [pdfium : main]

0 views

Skip to first unread message

Andy Phan (Gerrit)

unread,

Feb 20, 2026, 8:12:19 PM (2 days ago) Feb 20

to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com

Attention needed from Andy Phan

Andy Phan added 3 comments

Patchset-level comments

File-level comment, Patchset 2:

Lei Zhang . unresolved

WDYT about moving to core/fxge/fx_font.h instead?

Andy Phan

That works too. Will get to this next week. Unresolving.

Commit Message

Line 7, Patchset 2:Move and use MaybeRemoveSubsettedFontPrefix()

Lei Zhang . resolved

"reuse"

Andy Phan

Done

File core/fpdfapi/font/cpdf_simplefont.cpp

Line 248, Patchset 2 (Parent): if (base_font_name_.GetLength() > 7 && base_font_name_[6] == '+') {

Lei Zhang . unresolved

It's also different because it expects the name to be at least "??????+?", while MaybeRemoveSubsettedFontPrefix() is trying to match "XXXXXX+".

Andy Phan

I can re-add the length check.

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Feb 20, 2026, 8:15:26 PM (2 days ago) Feb 20

to Andy Phan, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com

Attention needed from Andy Phan

Lei Zhang added 1 comment

File core/fpdfapi/font/cpdf_simplefont.cpp

Line 248, Patchset 2 (Parent): if (base_font_name_.GetLength() > 7 && base_font_name_[6] == '+') {

Lei Zhang . resolved

It's also different because it expects the name to be at least "??????+?", while MaybeRemoveSubsettedFontPrefix() is trying to match "XXXXXX+".

Andy Phan

I can re-add the length check.

Lei Zhang

I'm not sure how much it matters, since PDFs usually won't have just "XXXXXX+" as the font name. Just mentioning this since it's another subtle difference.

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages