Remove MTContext [pdfium : main]
Lei Zhang (Gerrit)
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
mt_[0] = seed;
for (uint32_t i = 1; i < kN; i++) {
const uint32_t prev = mt_[i - 1];
mt_[i] = (1812433253UL * (prev ^ (prev >> 30)) + i);
}Move the init code into a separate function. Then initialize both member variables in the initializer list.
Related details
- Andy Phan
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andy Phan (Gerrit)
Andy Phan added 1 comment![]( "Open in Gerrit")
mt_[0] = seed;
for (uint32_t i = 1; i < kN; i++) {
const uint32_t prev = mt_[i - 1];
mt_[i] = (1812433253UL * (prev ^ (prev >> 30)) + i);
}Move the init code into a separate function. Then initialize both member variables in the initializer list.
- Lei Zhang
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
mt_[0] = seed;
for (uint32_t i = 1; i < kN; i++) {
const uint32_t prev = mt_[i - 1];
mt_[i] = (1812433253UL * (prev ^ (prev >> 30)) + i);
}Andy PhanMove the init code into a separate function. Then initialize both member variables in the initializer list.
Made Init(), but does `mt_` need to be the initializer list?
I was thinking Init() can be in the anonymous namespace and return `std::array<uint32_t, kN>`.
Related details
- Andy Phan
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andy Phan (Gerrit)
Andy Phan added 1 comment![]( "Open in Gerrit")
mt_[0] = seed;
for (uint32_t i = 1; i < kN; i++) {
const uint32_t prev = mt_[i - 1];
mt_[i] = (1812433253UL * (prev ^ (prev >> 30)) + i);
}Andy PhanMove the init code into a separate function. Then initialize both member variables in the initializer list.
Lei ZhangMade Init(), but does `mt_` need to be the initializer list?
I was thinking Init() can be in the anonymous namespace and return `std::array<uint32_t, kN>`.
Done, although had to make kN public.
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
mt_[0] = seed;
for (uint32_t i = 1; i < kN; i++) {
const uint32_t prev = mt_[i - 1];
mt_[i] = (1812433253UL * (prev ^ (prev >> 30)) + i);
}Andy PhanMove the init code into a separate function. Then initialize both member variables in the initializer list.
Lei ZhangMade Init(), but does `mt_` need to be the initializer list?
Andy PhanI was thinking Init() can be in the anonymous namespace and return `std::array<uint32_t, kN>`.
Done, although had to make kN public.
- Andy Phan
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Remove MTContext
MTContext is only used as a member field for FX_Random, so just move the
struct's fields to FX_Random.
- M core/fxcrt/fx_random.cpp
- M core/fxcrt/fx_random.h
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |