Consolidate more font loading code. [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Mar 11, 2026, 6:03:10 PM (6 days ago) Mar 11
to Pdfium LUCI CQ, pdfium-...@googlegroups.com
Tom Sepez voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Mar 12, 2026, 2:06:38 PM (5 days ago) Mar 12
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Sepez
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Tom Sepez . resolved
Last one in this chain (well, rebased onto main).
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Mar 12, 2026, 2:15:03 PM (5 days ago) Mar 12
to Tom Sepez, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Mar 12, 2026, 2:15:21 PM (5 days ago) Mar 12
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Tom Sepez voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Mar 12, 2026, 2:16:53 PM (5 days ago) Mar 12
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Consolidate more font loading code.
Make loading from span call into loading from span stream.
-- Rename one function to indicate it always loads face 0.
Change-Id: I8d7de4c5c56aa2bedb549001c97de90521d00b82
Commit-Queue: Tom Sepez <tse...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Files:
- M core/fpdfapi/font/cpdf_font.cpp
- M core/fxge/cfx_font.cpp
- M core/fxge/cfx_font.h
- M fpdfsdk/fpdf_edittext.cpp
- M xfa/fgas/font/cfgas_fontmgr.cpp
Change size: M
Delta: 5 files changed, 33 insertions(+), 34 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages