Refactor CPVT_Word caret calculations [pdfium : main]
0 views
Skip to first unread message
Lei Zhang (Gerrit)
Jun 23, 2026, 4:27:26 PM (2 days ago) Jun 23
to Seung Hyun Jin, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Seung Hyun Jin
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
File core/fpdfdoc/cpvt_word.h
Line 42, Patchset 1 (Latest):
float GetCaretX() const { return location_.x + width_; }Lei Zhang . unresolved
AscentY() and DescentY() are very similar, but they do not have the "Get" prefix. Omit that for consistency?
Related details
Attention is currently required from:
- Seung Hyun Jin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 23, 2026, 4:44:56 PM (2 days ago) Jun 23
to Seung Hyun Jin, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Seung Hyun Jin
Lei Zhang added 1 comment![]( "Open in Gerrit")
File fpdfsdk/pwl/cpwl_edit_impl.cpp
Line 1230, Patchset 1 (Latest):
ptFoot.x = ptHead.x;Lei Zhang . unresolved
Also mention reducing GetCaretX() calls by reusing the results in the CL description.
Related details
Attention is currently required from:
- Seung Hyun Jin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Seung Hyun Jin (Gerrit)
Jun 23, 2026, 4:56:55 PM (2 days ago) Jun 23
to Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Seung Hyun Jin added 2 comments![]( "Open in Gerrit")
File core/fpdfdoc/cpvt_word.h
AscentY() and DescentY() are very similar, but they do not have the "Get" prefix. Omit that for consistency?
Seung Hyun Jin
Done
File fpdfsdk/pwl/cpwl_edit_impl.cpp
Also mention reducing GetCaretX() calls by reusing the results in the CL description.
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 23, 2026, 4:59:58 PM (2 days ago) Jun 23
to Seung Hyun Jin, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Seung Hyun Jin
Lei Zhang added 1 comment![]( "Open in Gerrit")
File core/fpdfdoc/cpvt_word.h
Line 42, Patchset 3 (Latest):
float CaretX() const { return location_.x + width_; }Lei Zhang . unresolved
One more nit: How about putting this above AscentY(), since most people think of "x/y" coordinates. As such, the x-coordinate getters should come before the y-coordinate getters.
Related details
Attention is currently required from:
- Seung Hyun Jin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Seung Hyun Jin (Gerrit)
Jun 23, 2026, 5:12:34 PM (2 days ago) Jun 23
to Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Seung Hyun Jin added 1 comment![]( "Open in Gerrit")
File core/fpdfdoc/cpvt_word.h
One more nit: How about putting this above AscentY(), since most people think of "x/y" coordinates. As such, the x-coordinate getters should come before the y-coordinate getters.
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 23, 2026, 5:15:56 PM (2 days ago) Jun 23
to Seung Hyun Jin, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Seung Hyun Jin
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Seung Hyun Jin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Seung Hyun Jin (Gerrit)
Jun 23, 2026, 5:26:28 PM (2 days ago) Jun 23
to Lei Zhang, pdfium-...@googlegroups.com
Seung Hyun Jin voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 23, 2026, 6:21:23 PM (2 days ago) Jun 23
to Seung Hyun Jin, Lei Zhang, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Refactor CPVT_Word caret calculations
Add `CaretX()` to simplify caret coordinate calculations. Reduce
`CaretX()` calls by reusing the results.
Bug: 40115028
Change-Id: I982471e262ac57401dcfb79aca77ff0ec65d92d6
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/150530
Commit-Queue: Seung Hyun Jin <seungh...@google.com>
Reviewed-by: Lei Zhang <the...@chromium.org>
Files:
- M core/fpdfdoc/cpvt_word.h
- M fpdfsdk/pwl/cpwl_edit.cpp
- M fpdfsdk/pwl/cpwl_edit_impl.cpp
Change size: S
Delta: 3 files changed, 16 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages