Assume a value of 0 to prevent float-cast-overflow. [pdfium : main]

0 views
Skip to first unread message

Brendan Lundy (Gerrit)

unread,
Feb 19, 2026, 8:26:32 PM (3 days ago) Feb 19
to Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

Brendan Lundy added 5 comments

Commit Message
Line 7, Patchset 1:Assume a value of 0 to prevent overflow.
Lei Zhang . resolved

To be more specific: float-cast-overflow

Brendan Lundy

Done

Line 10, Patchset 1:line caps see ISO 32000-1:2008 table 52
Lei Zhang . resolved

and line joins

Brendan Lundy

Done

Line 15, Patchset 1:Change-Id: Ifbae9d456b00a94729f665dae22165fe2344b676
Lei Zhang . resolved

Can add a new line above with `Bug: 40498655, 485686789`

Brendan Lundy

Done

File core/fpdfapi/page/cpdf_streamcontentparser.h
Line 95, Patchset 1: if (!pdfium::IsValueInRangeForNumericType<int>(num)) {
Lei Zhang . resolved

Should `#include "core/fxcrt/numerics/safe_conversions.h"` for this.

Brendan Lundy

Done

Line 94, Patchset 1: float num = GetNumber(index);
Lei Zhang . resolved

Move the impl into the .cpp file, considering it's no longer trivial?

Brendan Lundy

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ifbae9d456b00a94729f665dae22165fe2344b676
Gerrit-Change-Number: 143413
Gerrit-PatchSet: 3
Gerrit-Owner: Brendan Lundy <brenda...@google.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 01:26:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Feb 19, 2026, 8:31:00 PM (3 days ago) Feb 19
to Brendan Lundy, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Brendan Lundy

Lei Zhang voted

Code-Review+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brendan Lundy
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ifbae9d456b00a94729f665dae22165fe2344b676
Gerrit-Change-Number: 143413
Gerrit-PatchSet: 3
Gerrit-Owner: Brendan Lundy <brenda...@google.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Brendan Lundy <brenda...@google.com>
Gerrit-Comment-Date: Fri, 20 Feb 2026 01:30:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Brendan Lundy (Gerrit)

unread,
Feb 19, 2026, 8:33:53 PM (3 days ago) Feb 19
to Pdfium LUCI CQ, Lei Zhang, pdfium-...@googlegroups.com

Brendan Lundy voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ifbae9d456b00a94729f665dae22165fe2344b676
Gerrit-Change-Number: 143413
Gerrit-PatchSet: 3
Gerrit-Owner: Brendan Lundy <brenda...@google.com>
Gerrit-Reviewer: Brendan Lundy <brenda...@google.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 01:33:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Feb 19, 2026, 10:14:39 PM (3 days ago) Feb 19
to Brendan Lundy, Andy Phan, Pdfium LUCI CQ, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Brendan Lundy and Lei Zhang

Lei Zhang voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
  • Brendan Lundy
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ifbae9d456b00a94729f665dae22165fe2344b676
Gerrit-Change-Number: 143413
Gerrit-PatchSet: 3
Gerrit-Owner: Brendan Lundy <brenda...@google.com>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Brendan Lundy <brenda...@google.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Brendan Lundy <brenda...@google.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 03:14:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Feb 20, 2026, 1:58:39 PM (2 days ago) Feb 20
to Brendan Lundy, Andy Phan, Pdfium LUCI CQ, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Andy Phan and Brendan Lundy

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
  • Brendan Lundy
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ifbae9d456b00a94729f665dae22165fe2344b676
Gerrit-Change-Number: 143413
Gerrit-PatchSet: 3
Gerrit-Owner: Brendan Lundy <brenda...@google.com>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Brendan Lundy <brenda...@google.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Brendan Lundy <brenda...@google.com>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 18:58:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Pdfium LUCI CQ (Gerrit)

unread,
Feb 20, 2026, 2:02:01 PM (2 days ago) Feb 20
to Brendan Lundy, Andy Phan, Lei Zhang, pdfium-...@googlegroups.com

Pdfium LUCI CQ submitted the change

Change information

Commit message:
Assume a value of 0 to prevent float-cast-overflow.

Per thestig@
line joins and line caps see ISO 32000-1:2008 table 52
text rendering mode table 105

Overflow shouldn't happen with real PDFs.
Bug: 40498655, 485686789
Change-Id: Ifbae9d456b00a94729f665dae22165fe2344b676
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Files:
  • M core/fpdfapi/page/cpdf_streamcontentparser.cpp
  • M core/fpdfapi/page/cpdf_streamcontentparser.h
Change size: S
Delta: 2 files changed, 14 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Lei Zhang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ifbae9d456b00a94729f665dae22165fe2344b676
Gerrit-Change-Number: 143413
Gerrit-PatchSet: 4
Gerrit-Owner: Brendan Lundy <brenda...@google.com>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Brendan Lundy <brenda...@google.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages