Remove FPDF_ClosePage() calls in fpdf_edit_embeddertest.cpp [pdfium : main]

0 views

Skip to first unread message

Andy Phan (Gerrit)

unread,

Mar 12, 2026, 6:53:37 PM (5 days ago) Mar 12

to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com

Attention needed from Lei Zhang

Andy Phan voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Pdfium LUCI CQ (Gerrit)

unread,

Mar 12, 2026, 8:12:06 PM (5 days ago) Mar 12

to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com

Pdfium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: fpdfsdk/fpdf_edit_embeddertest.cpp
Insertions: 6, Deletions: 7.

@@ -2221,13 +2221,13 @@
   ASSERT_EQ(0, FPDFPage_CountObjects(page.get()));
 
   // Add a red rectangle.
-  ScopedFPDFPageObject red_rect(FPDFPageObj_CreateNewRect(10, 10, 20, 20));
+  ScopedFPDFPageObject red_rect_deleter(
+      FPDFPageObj_CreateNewRect(10, 10, 20, 20));
+  FPDF_PAGEOBJECT red_rect = red_rect_deleter.get();
   ASSERT_TRUE(red_rect);
-  EXPECT_TRUE(FPDFPageObj_SetFillColor(red_rect.get(), 255, 0, 0, 255));
-  EXPECT_TRUE(FPDFPath_SetDrawMode(red_rect.get(), FPDF_FILLMODE_ALTERNATE, 0));
-  // Not calling release() since ownership will be returned below in the
-  // FPDFPage_RemoveObject() call.
-  FPDFPage_InsertObject(page.get(), red_rect.get());
+  EXPECT_TRUE(FPDFPageObj_SetFillColor(red_rect, 255, 0, 0, 255));
+  EXPECT_TRUE(FPDFPath_SetDrawMode(red_rect, FPDF_FILLMODE_ALTERNATE, 0));
+  FPDFPage_InsertObject(page.get(), red_rect_deleter.release());
   {
     ScopedFPDFBitmap page_bitmap = RenderPage(page.get());
     CompareBitmap(page_bitmap.get(), kRedRectanglePng);
@@ -2236,7 +2236,8 @@
 
   // Remove rectangle and verify it does not render anymore and the bitmap is
   // back to a blank one.
-  EXPECT_TRUE(FPDFPage_RemoveObject(page.get(), red_rect.get()));
+  EXPECT_TRUE(FPDFPage_RemoveObject(page.get(), red_rect));
+  red_rect_deleter.reset(red_rect);
   {
     ScopedFPDFBitmap page_bitmap = RenderPage(page.get());
     CompareBitmap(page_bitmap.get(), kBlankPage612By792Png);
@@ -2244,7 +2245,7 @@
   EXPECT_EQ(0, FPDFPage_CountObjects(page.get()));
 
   // Trying to remove an object not in the page should return false.
-  EXPECT_FALSE(FPDFPage_RemoveObject(page.get(), red_rect.get()));
+  EXPECT_FALSE(FPDFPage_RemoveObject(page.get(), red_rect));
 }
 
 TEST_F(FPDFEditEmbedderTest, PathsPoints) {
```

Change information

Commit message:

Remove FPDF_ClosePage() calls in fpdf_edit_embeddertest.cpp

Use ScopedFPDFPage instead.

Change-Id: I2a7d176c3e228083bb5b9cb050e6bfed231d94e6

Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/144754

Commit-Queue: Lei Zhang <the...@chromium.org>

Reviewed-by: Andy Phan <andy...@chromium.org>

Files:

M fpdfsdk/fpdf_edit_embeddertest.cpp

Change size: M

Delta: 1 file changed, 60 insertions(+), 72 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Andy Phan

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages