Replace macro-based modifiers with WSTRModifiers enum [pdfium : main]
0 views
Skip to first unread message
Aryan Krishnan (Gerrit)
Mar 25, 2026, 2:29:57 PMMar 25
to Pdfium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
Commit Message
Line 7, Patchset 8:
Replace macro-based modifiers with WSTRModifiers structLei Zhang . resolved
Aryan KrishnanAs always, reminder to rewrite the CL description to match the actual code.
Yep forgot to replace here, mb. Done.
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
Mar 25, 2026, 2:32:53 PMMar 25
to Pdfium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
File core/fxcrt/widestring.cpp
Line 145, Patchset 8:
bool wide = (view.Front() == 's');Lei Zhang . resolved
Aryan KrishnanCan skip this computation:
```
bool wide;
if (nModifier == WSTRModifier::kForceUnicode) {
wide = true;
} else if (nModifier == WSTRModifier::kForceAnsi) {
wide = false;
} else {
wide = (view.Front() == 's');
}
```
Done
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Mar 25, 2026, 4:03:52 PMMar 25
to Aryan Krishnan, Lei Zhang, Pdfium LUCI CQ, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Aryan Krishnan and Tom Sepez
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
File core/fxcrt/widestring.cpp
Line 35, Patchset 10 (Latest):
enum class WSTRModifier {Lei Zhang . unresolved
Move this closer to where used.
Related details
Attention is currently required from:
- Andy Phan
- Aryan Krishnan
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
Mar 25, 2026, 4:13:11 PMMar 25
to Lei Zhang, Pdfium LUCI CQ, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Aryan Krishnan
| Commit-Queue | +1 |
1 comment
File core/fxcrt/widestring.cpp
Move this closer to where used.
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Mar 25, 2026, 4:14:29 PMMar 25
to Aryan Krishnan, Lei Zhang, Pdfium LUCI CQ, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Aryan Krishnan and Tom Sepez
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andy Phan
- Aryan Krishnan
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
Mar 27, 2026, 4:40:48 AMMar 27
to Lei Zhang, Pdfium LUCI CQ, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan and Tom Sepez
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Andy Phan
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andy Phan (Gerrit)
Mar 27, 2026, 3:05:01 PMMar 27
to Aryan Krishnan, Lei Zhang, Pdfium LUCI CQ, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan and Tom Sepez
Andy Phan voted and added 2 comments![]( "Open in Gerrit")
Votes added by Andy Phan
| Code-Review | +1 |
2 comments
File core/fxcrt/widestring.cpp
Line 57, Patchset 11 (Latest):
kForceNone,Andy Phan . unresolved
Consider omitting "Force" here, so it's just `kNone`.
Line 58, Patchset 11 (Latest):
kForceAnsi,Andy Phan . unresolved
Thoughts on also omitting "Force" for the other entries?
Related details
Attention is currently required from:
- Aryan Krishnan
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
Mar 27, 2026, 9:45:04 PMMar 27
to Andy Phan, Lei Zhang, Pdfium LUCI CQ, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan added 2 comments![]( "Open in Gerrit")
File core/fxcrt/widestring.cpp
Consider omitting "Force" here, so it's just `kNone`.
Aryan Krishnan
Done.
Line 58, Patchset 11:
kForceAnsi,Andy Phan . unresolved
Thoughts on also omitting "Force" for the other entries?
Aryan Krishnan
I'd say for these lets keep it, the old #defines were named as `FORCE_SOMETHING`, so I think we should include the force to try keep the name consistent @the...@chromium.org?
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Apr 9, 2026, 4:22:07 PM (2 days ago) Apr 9
to Aryan Krishnan, Andy Phan, Lei Zhang, Pdfium LUCI CQ, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Aryan Krishnan and Tom Sepez
Lei Zhang added 2 comments![]( "Open in Gerrit")
File core/fxcrt/widestring.cpp
Line 58, Patchset 11:
kForceAnsi,Andy Phan . resolved
Aryan KrishnanThoughts on also omitting "Force" for the other entries?
I'd say for these lets keep it, the old #defines were named as `FORCE_SOMETHING`, so I think we should include the force to try keep the name consistent @the...@chromium.org?
Lei Zhang
I'm fine with keeping it as-is.
Line 115, Patchset 12 (Latest):
WSTRModifier nModifier = WSTRModifier::kForceNone;Lei Zhang . unresolved
Need to update this so the latest patchset compiles.
Related details
Attention is currently required from:
- Andy Phan
- Aryan Krishnan
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
Apr 9, 2026, 10:11:25 PM (2 days ago) Apr 9
to Andy Phan, Lei Zhang, Pdfium LUCI CQ, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Aryan Krishnan
| Commit-Queue | +1 |
1 comment
File core/fxcrt/widestring.cpp
Need to update this so the latest patchset compiles.
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Apr 9, 2026, 10:55:44 PM (2 days ago) Apr 9
to Aryan Krishnan, Lei Zhang, Andy Phan, Pdfium LUCI CQ, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Aryan Krishnan and Tom Sepez
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andy Phan
- Aryan Krishnan
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages