Rename FX_LINEBREAKTYPE to LineBreakType [pdfium : main]

[Aryan Krishnan (Gerrit)]

Attention needed from Helmut Januschka

Aryan Krishnan added 3 comments

Commit Message

Line 9, Patchset 1 (Latest):Bring the enum class and its values in line with PDFium naming conventions: drop the FX_ prefix, switch values from SCREAMING_SNAKE to CamelCase, and spell out BRK as Break/Common.

Aryan Krishnan . unresolved

Minor nit: should be

```suggestion
Bring the enum class and its values in line with PDFium naming conventions by dropping the FX_ prefix, switching values from SCREAMING_SNAKE to CamelCase, and spelling out BRK as Break/Common.
```

And then wrap.

File xfa/fgas/layout/fgas_linebreak.h

Line 13, Patchset 1 (Latest):
enum class LineBreakType : uint8_t {
kUnknown = 0x00,
kDirectBreak = 0x1A,
kIndirectBreak = 0x2B,
kCommonIndirectBreak = 0x3C,
kCommonProhibitedBreak = 0x4D,
kProhibitedBreak = 0x5E,
kHangulSpaceBreak = 0x6F,
};

LineBreakType GetLineBreakTypeFromPair(FX_BREAKPROPERTY curr_char,
FX_BREAKPROPERTY next_char);

Aryan Krishnan . unresolved

Can this go inside a struct, or a class or something of that sort, leaving it in the global namespace may not be best.

File xfa/fgas/layout/fgas_linebreak.cpp

Line 25, Patchset 1 (Latest):#define FX_LBPB LineBreakType::kProhibitedBreak

Aryan Krishnan . resolved

Not needed for this CL, but a general point: I noticed another one of your CLs that replaces these with constexprs. No need to rework anything here, but maybe consider chaining CLs together in future to avoid rebase/merge conflicts if one lands before the other.

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: I949be71f751c7255a5f92e0f8011e7c49f13cf5e

Gerrit-Change-Number: 148832

Gerrit-PatchSet: 1

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>

Gerrit-CC: pdfium...@luci-project-accounts.iam.gserviceaccount.com <pdfium...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Comment-Date: Sun, 31 May 2026 17:40:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No