Roll third_party/harfbuzz/src/ a243dcb5c..e6741e220 (406 commits) [pdfium : main]

2 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
May 7, 2026, 7:44:57 PM (6 days ago) May 7
to Andy Phan, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Andy Phan

Lei Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I2a12d8ae729c9924b694eecb51c9eb3db263afbb
Gerrit-Change-Number: 147054
Gerrit-PatchSet: 9
Gerrit-Owner: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Thu, 07 May 2026 23:44:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andy Phan (Gerrit)

unread,
May 7, 2026, 7:46:27 PM (6 days ago) May 7
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Andy Phan voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I2a12d8ae729c9924b694eecb51c9eb3db263afbb
Gerrit-Change-Number: 147054
Gerrit-PatchSet: 9
Gerrit-Owner: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Thu, 07 May 2026 23:46:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
May 7, 2026, 7:47:43 PM (6 days ago) May 7
to Andy Phan, Lei Zhang, pdfium-...@googlegroups.com

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Roll third_party/harfbuzz/src/ a243dcb5c..e6741e220 (406 commits)

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/a243dcb5c447..e6741e220530

[1] introduces a relationship between HB_NO_DRAW and HB_NO_OT_FONT_CFF
in hb-config.hh. PDFium wants HB_NO_DRAW but still needs CFF support for
subsetting. Use the same temporary override as
https://crrev.com/c/7799984.

Created with:
roll-dep third_party/harfbuzz/src

[1]
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+/bd645e5573a435e7cd4dfbce0c0a6f9334b8cfa1
Bug: 507839557
Change-Id: I2a12d8ae729c9924b694eecb51c9eb3db263afbb
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Andy Phan <andy...@chromium.org>
Files:
  • M DEPS
  • M third_party/harfbuzz/BUILD.gn
  • M third_party/harfbuzz/README.pdfium
  • A third_party/harfbuzz/pdfium-config-override.h
Change size: S
Delta: 4 files changed, 33 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Lei Zhang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I2a12d8ae729c9924b694eecb51c9eb3db263afbb
Gerrit-Change-Number: 147054
Gerrit-PatchSet: 10
Gerrit-Owner: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages