Remove unused nTotalWord field from struct CPVT_LineInfo [pdfium : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Jun 22, 2026, 9:14:49 PM (2 days ago) Jun 22
to Lei Zhang, Andy Phan, Seung Hyun Jin, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Andy Phan

Lei Zhang voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I386527b80c7223f2005b3beaf740897245f1700a
Gerrit-Change-Number: 150490
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Seung Hyun Jin <seungh...@google.com>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Jun 2026 01:14:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Andy Phan (Gerrit)

unread,
Jun 23, 2026, 12:25:38 PM (2 days ago) Jun 23
to Lei Zhang, Seung Hyun Jin, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

Andy Phan voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I386527b80c7223f2005b3beaf740897245f1700a
Gerrit-Change-Number: 150490
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Seung Hyun Jin <seungh...@google.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Jun 2026 16:25:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jun 23, 2026, 12:26:44 PM (2 days ago) Jun 23
to Lei Zhang, Andy Phan, Seung Hyun Jin, pdfium-...@googlegroups.com

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Remove unused nTotalWord field from struct CPVT_LineInfo

Only written into and never read from.
Change-Id: I386527b80c7223f2005b3beaf740897245f1700a
Auto-Submit: Lei Zhang <the...@chromium.org>
Commit-Queue: Andy Phan <andy...@chromium.org>
Reviewed-by: Andy Phan <andy...@chromium.org>
Files:
  • M core/fpdfdoc/cpvt_lineinfo.h
  • M core/fpdfdoc/cpvt_section.cpp
Change size: XS
Delta: 2 files changed, 0 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Andy Phan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I386527b80c7223f2005b3beaf740897245f1700a
Gerrit-Change-Number: 150490
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages