Add metadata-validator to PDFium [pdfium : infra/config]

[Lei Zhang (Gerrit)]

Attention needed from Jordan Brown

Lei Zhang added 3 comments

Commit Message

Line 9, Patchset 2 (Latest):Bug: b/479262293

Lei Zhang . unresolved

Prefix not needed. It's all the same issue track in the end.

File main.star

Line 122, Patchset 2 (Latest): properties.update({"use_cxx23": True})

Lei Zhang . resolved

Thanks.

Line 465, Patchset 2 (Latest): name = "metadata-validator",

Lei Zhang . unresolved

Line 440 uses an underscore between words, so can this name be consistent with that? More below.

Open in Gerrit

Related details

Attention is currently required from:

• Jordan Brown

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: infra/config

Gerrit-Change-Id: I8b21bb5f2caae1aa62992791875d7f8e61924e3a

Gerrit-Change-Number: 143471

Gerrit-PatchSet: 2

Gerrit-Owner: Jordan Brown <r...@google.com>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-Attention: Jordan Brown <r...@google.com>

Gerrit-Comment-Date: Fri, 20 Feb 2026 08:03:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No