Assume a value of 0 to prevent overflow. [pdfium : main]

[Lei Zhang (Gerrit)]

Attention needed from Brendan Lundy

Lei Zhang voted and added 6 comments

Votes added by Lei Zhang

Code-Review

+1

6 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Lei Zhang . resolved

Thanks! Just nits:

Commit Message

Line 7, Patchset 1 (Latest):Assume a value of 0 to prevent overflow.

Lei Zhang . unresolved

To be more specific: float-cast-overflow

Line 10, Patchset 1 (Latest):line caps see ISO 32000-1:2008 table 52

Lei Zhang . unresolved

and line joins

Line 15, Patchset 1 (Latest):Change-Id: Ifbae9d456b00a94729f665dae22165fe2344b676

Lei Zhang . unresolved

Can add a new line above with `Bug: 40498655, 485686789`

File core/fpdfapi/page/cpdf_streamcontentparser.h

Line 95, Patchset 1 (Latest): if (!pdfium::IsValueInRangeForNumericType<int>(num)) {

Lei Zhang . unresolved

Should `#include "core/fxcrt/numerics/safe_conversions.h"` for this.

Line 94, Patchset 1 (Latest): float num = GetNumber(index);

Lei Zhang . unresolved

Move the impl into the .cpp file, considering it's no longer trivial?

Open in Gerrit

Related details

Attention is currently required from:

• Brendan Lundy

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: Ifbae9d456b00a94729f665dae22165fe2344b676

Gerrit-Change-Number: 143413

Gerrit-PatchSet: 1

Gerrit-Owner: Brendan Lundy <brenda...@google.com>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-Attention: Brendan Lundy <brenda...@google.com>

Gerrit-Comment-Date: Fri, 20 Feb 2026 01:18:17 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes