Remove CFX_AggClipRgn from CFX_DIBBase. [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Feb 20, 2026, 6:51:11 PM (2 days ago) Feb 20
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Feb 20, 2026, 7:16:27 PM (2 days ago) Feb 20
to Tom Sepez, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
File core/fxge/dib/cfx_dibitmap.h
Line 21, Patchset 1 (Latest):
#include "core/fxge/agg/cfx_agg_cliprgn.h"Lei Zhang . unresolved
Can forward declare.
Related details
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Feb 20, 2026, 7:54:51 PM (2 days ago) Feb 20
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Tom Sepez added 1 comment![]( "Open in Gerrit")
File core/fxge/dib/cfx_dibitmap.h
Line 21, Patchset 1:
#include "core/fxge/agg/cfx_agg_cliprgn.h"Lei Zhang . resolved
Tom SepezCan forward declare.
Done
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Feb 20, 2026, 8:47:37 PM (2 days ago) Feb 20
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Tom Sepez voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Feb 20, 2026, 8:48:45 PM (2 days ago) Feb 20
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: core/fxge/dib/cfx_dibitmap.h
Insertions: 2, Deletions: 1.
@@ -18,10 +18,11 @@
#include "core/fxcrt/retain_ptr.h"
#include "core/fxcrt/span.h"
#include "core/fxcrt/span_util.h"
-#include "core/fxge/agg/cfx_agg_cliprgn.h"
#include "core/fxge/dib/cfx_dibbase.h"
#include "core/fxge/dib/fx_dib.h"
+class CFX_AggClipRgn;
+
class CFX_DIBitmap final : public CFX_DIBBase {
public:
struct PitchAndSize {
```
Change information
Commit message:
Remove CFX_AggClipRgn from CFX_DIBBase.
It only needs to know about FX_RECT boxes, not masks.
Bug: 485984630
Change-Id: I947eedf7e5f62ec331c73d2045ee847be4fc3e43
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Files:
- M core/fxge/dib/cfx_dibbase.cpp
- M core/fxge/dib/cfx_dibbase.h
- M core/fxge/dib/cfx_dibitmap.cpp
- M core/fxge/dib/cfx_dibitmap.h
Change size: S
Delta: 4 files changed, 10 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages