Rename GetDeviceCache() to GetSkTypeface(). [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Feb 19, 2026, 5:39:08 PM (3 days ago) Feb 19
to Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tom Sepez . resolved
fully automated rename, no funny business.
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Feb 19, 2026, 5:39:18 PM (3 days ago) Feb 19
to Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Feb 19, 2026, 5:41:44 PM (3 days ago) Feb 19
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted![]( "Open in Gerrit")
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Feb 19, 2026, 6:13:36 PM (3 days ago) Feb 19
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Rename GetDeviceCache() to GetSkTypeface().
The method only exists when Skia is enabled and always returns
a SkTypeface.
Change-Id: I28b768bfa4e4a6e1c2dda54868761ac226173cc2
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Auto-Submit: Tom Sepez <tse...@chromium.org>
Files:
- M core/fxge/cfx_font.cpp
- M core/fxge/cfx_font.h
- M core/fxge/cfx_glyphcache.cpp
- M core/fxge/cfx_glyphcache.h
- M core/fxge/skia/fx_skia_device.cpp
Change size: S
Delta: 5 files changed, 7 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages