Add a broken test for flattening AcroForms [pdfium : main]

0 views

Skip to first unread message

April Kallmeyer (Gerrit)

unread,

Apr 7, 2026, 4:52:49 PM (4 days ago) Apr 7

to Lei Zhang, pdfium-...@googlegroups.com

Attention needed from Lei Zhang

April Kallmeyer voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Apr 7, 2026, 4:59:04 PM (4 days ago) Apr 7

to April Kallmeyer, Pdfium LUCI CQ, Lei Zhang, pdfium-...@googlegroups.com

Attention needed from April Kallmeyer

Lei Zhang added 3 comments

Commit Message

Line 7, Patchset 1 (Latest):Add a broken test for flattening AcroForms

Lei Zhang . unresolved

Maybe write "Add a test to demonstrate a PDF flattening bug"

And then write a brief CL description to mention it is intentionally broken.

Line 10, Patchset 1 (Latest):Bug: 498010830

Lei Zhang . unresolved

Flip with line 9.

File fpdfsdk/fpdf_flatten_embeddertest.cpp

Line 128, Patchset 1 (Latest):TEST_F(FPDFFlattenEmbedderTest, AcroForm) {

Lei Zhang . unresolved

Maybe "FlattenShouldRemoveAcroForm"

Open in Gerrit

Related details

Attention is currently required from:

April Kallmeyer

Submit Requirements:

Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages