Replace BOM macros with constexpr constants [pdfium : main]
0 views
Skip to first unread message
Lei Zhang (Gerrit)
Jun 18, 2026, 6:12:07 PM (6 days ago) Jun 18
to Helmut Januschka, Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Helmut Januschka and Tom Sepez
Lei Zhang added 1 comment![]( "Open in Gerrit")
File core/fxcrt/cfx_seekablestreamproxy.cpp
Line 91, Patchset 4 (Latest):
enum class ByteOrderMark {Lei Zhang . unresolved
Thoughts on adding this enum class, vs. having DetectByteOrderMark() return FX_CodePage?
Related details
Attention is currently required from:
- Helmut Januschka
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Jun 18, 2026, 6:48:20 PM (6 days ago) Jun 18
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang and Tom Sepez
Helmut Januschka added 1 comment![]( "Open in Gerrit")
File core/fxcrt/cfx_seekablestreamproxy.cpp
Thoughts on adding this enum class, vs. having DetectByteOrderMark() return FX_CodePage?
Attention is currently required from:
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 18, 2026, 7:05:01 PM (6 days ago) Jun 18
to Helmut Januschka, Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Helmut Januschka and Tom Sepez
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Helmut Januschka
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Jun 24, 2026, 2:42:25 PM (12 hours ago) Jun 24
to Helmut Januschka, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Helmut Januschka
Tom Sepez voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Helmut Januschka
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 24, 2026, 3:44:00 PM (11 hours ago) Jun 24
to Helmut Januschka, Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Replace BOM macros with constexpr constants
Use anonymous namespace constants instead of preprocessor macros.
Bug: 42270078
Change-Id: I0654a6a0cfbd9e86a53e9fbb6c03866701b2cf5f
Reviewed-by: Lei Zhang <the...@chromium.org>
Reviewed-by: Tom Sepez <tse...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Files:
- M core/fxcrt/cfx_seekablestreamproxy.cpp
Change size: M
Delta: 1 file changed, 31 insertions(+), 23 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang, +1 by Tom Sepez
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 24, 2026, 5:47:45 PM (9 hours ago) Jun 24
to Helmut Januschka, pdfium...@luci-project-accounts.iam.gserviceaccount.com, Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Lei Zhang added 1 comment![]( "Open in Gerrit")
Commit Message
Line 2, Patchset 6 (Latest):
Author: chrome builder <hel...@januschka.com>Lei Zhang . resolved
Too late to change, but just wanted to point out the author field doesn't look right.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Jun 24, 2026, 5:55:17 PM (9 hours ago) Jun 24
to pdfium...@luci-project-accounts.iam.gserviceaccount.com, Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Helmut Januschka added 1 comment![]( "Open in Gerrit")
Commit Message
Line 2, Patchset 6 (Latest):
Author: chrome builder <hel...@januschka.com>Lei Zhang . resolved
Too late to change, but just wanted to point out the author field doesn't look right.
Helmut Januschka
meh, yeah i switched to a new machine, and "chrome builder" is actually the hostname :/ - super sorry, fixed it with git config
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages