Make equivalent Skia calls in CFX_Face under Fontations builds. [pdfium : main]

0 views

Skip to first unread message

Tom Sepez (Gerrit)

unread,

Mar 16, 2026, 12:27:00 PM (yesterday) Mar 16

to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com

Attention needed from Lei Zhang

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

8:31 PM (2 hours ago) 8:31 PM

to Tom Sepez, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com

Attention needed from Tom Sepez

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Code-Review

1 comment

File core/fxge/cfx_face.cpp

Line 35, Patchset 7 (Latest):

#include "third_party/skia/include/core/SkFont.h"         // nogncheck
#include "third_party/skia/include/core/SkFontMetrics.h"  // nogncheck
#include "third_party/skia/include/core/SkRect.h"         // nogncheck

Lei Zhang . unresolved

Put in separate PDF_ENABLE_SKIA_TYPEFACE_CHECKS section for now?