Better separate CFX_Font from CFX_Face [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Mar 16, 2026, 5:43:57 PM (yesterday) Mar 16
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Mar 16, 2026, 5:57:25 PM (yesterday) Mar 16
to Tom Sepez, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
2 comments
File core/fxge/cfx_face.h
Line 97, Patchset 9 (Latest):
const CFX_SubstFont* pSubstFont);Lei Zhang . unresolved
Avoid going back to Hungarian Notation.
Line 89, Patchset 9 (Latest):
bool bIsVertical,Lei Zhang . unresolved
Avoid adding Hungarian Notation.
Related details
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Mar 16, 2026, 6:18:35 PM (yesterday) Mar 16
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Tom Sepez voted and added 2 comments![]( "Open in Gerrit")
Votes added by Tom Sepez
| Commit-Queue | +2 |
2 comments
File core/fxge/cfx_face.h
Avoid going back to Hungarian Notation.
Tom Sepez
Done
Line 89, Patchset 9:
bool bIsVertical,Lei Zhang . resolved
Tom SepezAvoid adding Hungarian Notation.
Done
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Mar 16, 2026, 7:12:22 PM (yesterday) Mar 16
to Tom Sepez, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Mar 16, 2026, 7:22:28 PM (yesterday) Mar 16
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Tom Sepez voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Sepez
| Commit-Queue | +2 |
1 comment
File core/fxge/cfx_glyphcache.h
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Mar 16, 2026, 7:48:17 PM (yesterday) Mar 16
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
10 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: core/fxge/cfx_glyphcache.h
Insertions: 3, Deletions: 3.
@@ -54,12 +54,12 @@
using WidthMapKey = std::tuple<uint32_t, int, int>;
std::unique_ptr<CFX_GlyphBitmap> RenderGlyph(uint32_t glyph_index,
- bool bFontStyle,
- bool bIsVertical,
+ bool font_style,
+ bool is_vertical,
const CFX_Matrix& matrix,
int dest_width,
FontAntiAliasingMode anti_alias,
- const CFX_SubstFont* pSubstFont);
+ const CFX_SubstFont* subst_font);
CFX_GlyphBitmap* LookUpGlyphBitmap(const CFX_Font* font,
const CFX_Matrix& matrix,
const ByteString& FaceGlyphsKey,
```
```
The name of the file: core/fxge/cfx_glyphcache.cpp
Insertions: 5, Deletions: 5.
@@ -104,17 +104,17 @@
std::unique_ptr<CFX_GlyphBitmap> CFX_GlyphCache::RenderGlyph(
uint32_t glyph_index,
- bool bFontStyle,
- bool bIsVertical,
+ bool font_style,
+ bool is_vertical,
const CFX_Matrix& matrix,
int dest_width,
FontAntiAliasingMode anti_alias,
- const CFX_SubstFont* pSubstFont) {
+ const CFX_SubstFont* subst_font) {
if (!face_) {
return nullptr;
}
- return face_->RenderGlyph(glyph_index, bFontStyle, bIsVertical, matrix,
- dest_width, anti_alias, pSubstFont);
+ return face_->RenderGlyph(glyph_index, font_style, is_vertical, matrix,
+ dest_width, anti_alias, subst_font);
}
const CFX_Path* CFX_GlyphCache::LoadGlyphPath(const CFX_Font* font,
```
Change information
Commit message:
Better separate CFX_Font from CFX_Face
The checks in PS#1 show that the items that the face retrieves from
the font are already present, except for a bIsVertical flag. Achieve
better layering between the two classes.
-- Fix missing forward in cfx_fontmgr.h.
-- Comment purpose of CFX_SubstFont.
Change-Id: I3bd730a6a8d3a75ee3cea5c800df61e915ae2c4d
Commit-Queue: Tom Sepez <tse...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Files:
- M core/fxge/cfx_face.cpp
- M core/fxge/cfx_face.h
- M core/fxge/cfx_fontmgr.h
- M core/fxge/cfx_glyphcache.cpp
- M core/fxge/cfx_glyphcache.h
- M core/fxge/cfx_substfont.h
Change size: M
Delta: 6 files changed, 37 insertions(+), 34 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages