Update expectations for https://skia-review.googlesource.com/1150076 [pdfium_tests : main]
Lei Zhang (Gerrit)
Lei Zhang added 1 comment![]( "Open in Gerrit")
Is it expected that your Skia CL changes rendering?
Related details
- Ben Wagner
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Wagner (Gerrit)
Ben Wagner voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ben Wagner
| Code-Review | +1 |
1 comment
Is it expected that your Skia CL changes rendering?
Yes, the Skia CL changes rendering by default. At the moment it is possible to still get the old behavior by setting `SK_DISABLE_LEGACY_SHADERCONTEXT`, but that may be removed in the future.
Related details
- Lei Zhang
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Wagner (Gerrit)
Ben Wagner added 1 comment![]( "Open in Gerrit")
Ben WagnerIs it expected that your Skia CL changes rendering?
Yes, the Skia CL changes rendering by default. At the moment it is possible to still get the old behavior by setting `SK_DISABLE_LEGACY_SHADERCONTEXT`, but that may be removed in the future.
Hit the send button too soon. Meant to say the old behavior can still be had by setting `SK_ENABLE_LEGACY_SHADERCONTEXT` (`SK_DISABLE_LEGACY_SHADERCONTEXT` is the one that was removed).
Note that Chromium currently sets `SK_ENABLE_LEGACY_SHADERCONTEXT`, so the Pdfium build in Chromium will be using a Skia which has it set. So if these images are expected to draw the same Chromium side `SK_ENABLE_LEGACY_SHADERCONTEXT` will need to be used.
Related details
- Lei Zhang
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |