Change FXDIB_ALPHA_MERGE() from a macro to a function [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
May 12, 2026, 1:59:41 PM (yesterday) May 12
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Sepez
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tom Sepez . resolved
Ok, but Captain Entropy worries about that this is not namespaced, and removing the FX prefix may someday lead to a collision during link of unrelated code.
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
May 12, 2026, 3:14:38 PM (yesterday) May 12
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Lei Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Tom Sepez . resolved
Ok, but Captain Entropy worries about that this is not namespaced, and removing the FX prefix may someday lead to a collision during link of unrelated code.
Lei Zhang
Will put the entire header in a namespace in a follow-up.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
May 12, 2026, 3:14:40 PM (yesterday) May 12
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 12, 2026, 3:15:53 PM (yesterday) May 12
to Lei Zhang, Tom Sepez, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Change FXDIB_ALPHA_MERGE() from a macro to a function
Also rename it to AlphaMerge().
Bug: 42270078
Change-Id: I185c9e33e7a8445546d3894c96067d07c6069717
Reviewed-by: Tom Sepez <tse...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Files:
- M core/fxge/agg/cfx_agg_devicedriver.cpp
- M core/fxge/cfx_renderdevice.cpp
- M core/fxge/dib/cfx_dibitmap.cpp
- M core/fxge/dib/cfx_scanlinecompositor.cpp
- M core/fxge/dib/fx_dib.h
- M core/fxge/dib/fx_dib_unittest.cpp
Change size: L
Delta: 6 files changed, 178 insertions(+), 198 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tom Sepez
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages