Add MaybeOwnedDataVector and use in CJBig2_Image [pdfium : main]

0 views

Skip to first unread message

Lei Zhang (Gerrit)

unread,

May 12, 2026, 1:43:52 PM (yesterday) May 12

to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Attention needed from Tom Sepez

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Lei Zhang . resolved

Maybe?

Open in Gerrit

Related details

Attention is currently required from:

Tom Sepez

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tom Sepez (Gerrit)

unread,

May 12, 2026, 3:41:14 PM (yesterday) May 12

to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Attention needed from Lei Zhang

Tom Sepez voted and added 1 comment

Votes added by Tom Sepez

Code-Review

1 comment

File core/fxcrt/maybe_owned_data_vector.h

Line 19, Patchset 2 (Latest): using OwnedType = DataVector<T>;

Tom Sepez . unresolved

maybe make this a template argument, with Data vector<T> as a default, so you can pass in other foo types like FixedSizeDataVector.