Replace EM_ADJUST macro usage with NormalizeFontMetric() [pdfium : main]

0 views

Skip to first unread message

Aryan Krishnan (Gerrit)

unread,

2:08 PM (2 hours ago) 2:08 PM

to pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com

Attention needed from Andy Phan, Lei Zhang and Tom Sepez

Aryan Krishnan voted and added 2 comments

Votes added by Aryan Krishnan

Commit-Queue

2 comments

Patchset-level comments

File-level comment, Patchset 2:

Andy Phan . unresolved

The CL seems fine as a mechanical change, but maybe this should actually use NormalizeFontMetric() instead. There's multiple uses of it in the same file.

Aryan Krishnan

I assume you meant replace EmAdjust with NormalizeFontMetric. Done, also repurposed the <cmath> include for `std::roundll()` as a way to combine the + 0.5 and static_cast<> steps.

File core/fxge/cfx_face.cpp

Line 9, Patchset 2:#include <cmath>

Andy Phan . resolved

Unrelated to this CL, but maybe for std::abs()?

Aryan Krishnan

Not sure what you meant but the import was just me experimenting with `std::roundll()`, which I now added in the latest patchset.

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan
Lei Zhang
Tom Sepez

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Aryan Krishnan (Gerrit)

unread,

2:08 PM (2 hours ago) 2:08 PM

to pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com

Attention needed from Andy Phan, Lei Zhang and Tom Sepez

Aryan Krishnan added 1 comment

Patchset-level comments

File-level comment, Patchset 2:

Andy Phan . resolved

The CL seems fine as a mechanical change, but maybe this should actually use NormalizeFontMetric() instead. There's multiple uses of it in the same file.

Aryan Krishnan

I assume you meant replace EmAdjust with NormalizeFontMetric. Done, also repurposed the <cmath> include for `std::roundll()` as a way to combine the + 0.5 and static_cast<> steps.

Aryan Krishnan

Done

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan
Lei Zhang
Tom Sepez

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages