April Kallmeyer (Gerrit)

unread,

Jun 1, 2026, 7:05:06 PM (3 days ago) Jun 1

to Andy Phan, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Attention needed from Andy Phan and Lei Zhang

April Kallmeyer voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan
Lei Zhang

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Jun 1, 2026, 7:19:28 PM (3 days ago) Jun 1

to April Kallmeyer, Lei Zhang, Andy Phan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Attention needed from Andy Phan and April Kallmeyer

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Code-Review

+1

1 comment

Commit Message

Line 10, Patchset 2 (Latest):https://crrev.com/365c5520fa7531457866f73d3aea89ee7f433d56. It is required of v8 embedders now.

Lei Zhang . unresolved

1627152 is a bit shorter

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan
April Kallmeyer

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

April Kallmeyer (Gerrit)

unread,

Jun 1, 2026, 7:23:57 PM (3 days ago) Jun 1

to Lei Zhang, Andy Phan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Attention needed from Andy Phan and Lei Zhang

April Kallmeyer voted and added 1 comment

Votes added by April Kallmeyer

Auto-Submit

+1

1 comment

Commit Message

Line 10, Patchset 2:https://crrev.com/365c5520fa7531457866f73d3aea89ee7f433d56. It is required of v8 embedders now.

Lei Zhang . resolved

1627152 is a bit shorter

April Kallmeyer

Oh cool I forgot about that link format.

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan
Lei Zhang

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Andy Phan (Gerrit)

unread,

Jun 2, 2026, 1:20:05 PM (2 days ago) Jun 2

to April Kallmeyer, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Attention needed from April Kallmeyer and Lei Zhang

Andy Phan voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

April Kallmeyer
Lei Zhang

Submit Requirements:

Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Jun 2, 2026, 1:28:39 PM (2 days ago) Jun 2

to April Kallmeyer, Lei Zhang, Andy Phan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Attention needed from Andy Phan and April Kallmeyer

Lei Zhang voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan
April Kallmeyer

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Jun 2, 2026, 2:09:38 PM (2 days ago) Jun 2

to April Kallmeyer, Lei Zhang, Andy Phan, pdfium-...@googlegroups.com

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

Roll v8/ 8e10f842e..0c6c73eea (692 commits)

The same //third_party/llvm-libc/BUILD.gn change was made in Chromium in
https://crrev.com/1627152. It is required of v8 embedders now.

https://chromium.googlesource.com/v8/v8.git/+log/8e10f842e4b7..0c6c73eea699

Version 15.0.245

Created with:
  roll-dep v8

Change-Id: Iac2b50617c192040081a0741a0f7ce97ee7a42b8

Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/148952

Auto-Submit: April Kallmeyer <a...@chromium.org>

Reviewed-by: Andy Phan <andy...@chromium.org>

Reviewed-by: Lei Zhang <the...@chromium.org>

Commit-Queue: Lei Zhang <the...@chromium.org>

Files:

M DEPS
M third_party/llvm-libc/BUILD.gn

Change size: XS

Delta: 2 files changed, 6 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Lei Zhang, +1 by Andy Phan

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Roll v8/ 8e10f842e..0c6c73eea (692 commits) [pdfium : main]

April Kallmeyer (Gerrit)

April Kallmeyer voted Auto-Submit+1

Related details

Lei Zhang (Gerrit)

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

1 comment

Related details

April Kallmeyer (Gerrit)

April Kallmeyer voted and added 1 comment

Votes added by April Kallmeyer

1 comment

Related details

Andy Phan (Gerrit)

Andy Phan voted

Related details

Lei Zhang (Gerrit)

Lei Zhang voted

Related details

pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information