Cache data size in CJBig2_Image [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
May 12, 2026, 3:47:39 PM (yesterday) May 12
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
May 12, 2026, 3:59:40 PM (yesterday) May 12
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 12, 2026, 4:33:22 PM (24 hours ago) May 12
to Lei Zhang, Tom Sepez, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Cache data size in CJBig2_Image
Profiling shows GetLine() and other CJBig2_Image methods are all slow
because almost every access results in a `data_` size calculation. Avoid
that by caching the size.
Change-Id: I96dc0341e0533caf6af3f02a40caecb25cf3fbc3
Reviewed-by: Tom Sepez <tse...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Files:
- M core/fxcodec/jbig2/jbig2_image.cpp
- M core/fxcodec/jbig2/jbig2_image.h
Change size: S
Delta: 2 files changed, 20 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tom Sepez
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages