Make some fxge code Windows / AGG-only [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
May 8, 2026, 5:28:27 PM (5 days ago) May 8
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
May 8, 2026, 5:28:51 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 8, 2026, 5:29:55 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Make some fxge code Windows / AGG-only
Make CFX_RenderDevice::FillRect() fallback code Windows-only, since only
CGdiDeviceDriver can trigger this code. All other drivers that implement
RenderDeviceDriverIface::FillRect() will always succeed. After this,
CFX_DIBitmap::CompositeRect() becomes Windows/AGG-only.
Change-Id: I20530d463ec968ae0cdd68b3aa40cccf09568e27
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Tom Sepez <tse...@chromium.org>
Files:
- M core/fxge/cfx_renderdevice.cpp
- M core/fxge/dib/cfx_dibitmap.cpp
- M core/fxge/dib/cfx_dibitmap.h
Change size: XS
Delta: 3 files changed, 9 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tom Sepez
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages