Make some fxge code Windows / AGG-only [pdfium : main]

0 views
Skip to first unread message

Tom Sepez (Gerrit)

unread,
May 8, 2026, 5:28:27 PM (5 days ago) May 8
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

Tom Sepez voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I20530d463ec968ae0cdd68b3aa40cccf09568e27
Gerrit-Change-Number: 147370
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Fri, 08 May 2026 21:28:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
May 8, 2026, 5:28:51 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I20530d463ec968ae0cdd68b3aa40cccf09568e27
Gerrit-Change-Number: 147370
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Fri, 08 May 2026 21:28:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
May 8, 2026, 5:29:55 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, pdfium-...@googlegroups.com

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Make some fxge code Windows / AGG-only

Make CFX_RenderDevice::FillRect() fallback code Windows-only, since only
CGdiDeviceDriver can trigger this code. All other drivers that implement
RenderDeviceDriverIface::FillRect() will always succeed. After this,
CFX_DIBitmap::CompositeRect() becomes Windows/AGG-only.
Change-Id: I20530d463ec968ae0cdd68b3aa40cccf09568e27
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Tom Sepez <tse...@chromium.org>
Files:
  • M core/fxge/cfx_renderdevice.cpp
  • M core/fxge/dib/cfx_dibitmap.cpp
  • M core/fxge/dib/cfx_dibitmap.h
Change size: XS
Delta: 3 files changed, 9 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Tom Sepez
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I20530d463ec968ae0cdd68b3aa40cccf09568e27
Gerrit-Change-Number: 147370
Gerrit-PatchSet: 3
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages