Use fxcrt::Zip() in PDF_RenderStatus::LoadSMask(). [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Apr 8, 2026, 5:42:24 PM (3 days ago) Apr 8
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Apr 8, 2026, 6:02:43 PM (3 days ago) Apr 8
to Tom Sepez, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
File core/fpdfapi/render/cpdf_renderstatus.cpp
Line 1524, Patchset 3 (Latest):
for (auto [in, out] : fxcrt::Zip(src_buf.first(size), dest_buf)) {Lei Zhang . unresolved
Maybe reassign to `src_buf` on line 1522, get rid of `size`, and then use `src_buf` here and line line 1530.
Related details
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Apr 8, 2026, 6:16:34 PM (3 days ago) Apr 8
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Tom Sepez voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Sepez
| Commit-Queue | +2 |
1 comment
File core/fpdfapi/render/cpdf_renderstatus.cpp
Line 1524, Patchset 3:
for (auto [in, out] : fxcrt::Zip(src_buf.first(size), dest_buf)) {Lei Zhang . resolved
Maybe reassign to `src_buf` on line 1522, get rid of `size`, and then use `src_buf` here and line line 1530.
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Apr 8, 2026, 6:44:38 PM (3 days ago) Apr 8
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Tom Sepez voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Apr 8, 2026, 7:16:00 PM (3 days ago) Apr 8
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: core/fpdfapi/render/cpdf_renderstatus.cpp
Insertions: 3, Deletions: 3.
@@ -1519,15 +1519,15 @@
return result_mask;
}
- size_t size = Fx2DSizeOrDie(dest_pitch, height);
+ src_buf = src_buf.first(Fx2DSizeOrDie(dest_pitch, height));
if (pFunc) {
- for (auto [in, out] : fxcrt::Zip(src_buf.first(size), dest_buf)) {
+ for (auto [in, out] : fxcrt::Zip(src_buf, dest_buf)) {
out = transfers[in];
}
return result_mask;
}
- fxcrt::Copy(src_buf.first(size), dest_buf);
+ fxcrt::Copy(src_buf, dest_buf);
return result_mask;
}
```
Change information
Commit message:
Use fxcrt::Zip() in PDF_RenderStatus::LoadSMask().
Avoid some bounds checking during iteration.
-- Avoid some else-clauses while at it.
Change-Id: Id48e4af24ae7d8abad5d18be438c24fd872df92f
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Files:
- M core/fpdfapi/render/cpdf_renderstatus.cpp
Change size: S
Delta: 1 file changed, 13 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages