Make CFX_RenderDevice::Get{Horz,Vert}Size() Windows-only [pdfium : main]
0 views
Skip to first unread message
Aryan Krishnan (Gerrit)
May 8, 2026, 12:42:40 PM (5 days ago) May 8
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Aryan Krishnan added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Aryan Krishnan . unresolved
Based on the build logs also seems like cpdf_scaledrenderbuffer.cpp needs an update to remove the scale arg.
Commit Message
Line 16, Patchset 1 (Latest):
CPDF_DeviceBuffer::CalculateMatrix() as well.Aryan Krishnan . unresolved
nit: maybe another newline between content and change-id? Keeping it as is fine as well I just feel the newline looks cleaner.
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
May 8, 2026, 1:23:28 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan and Tom Sepez
Lei Zhang added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Based on the build logs also seems like cpdf_scaledrenderbuffer.cpp needs an update to remove the scale arg.
Lei Zhang
Done
Commit Message
nit: maybe another newline between content and change-id? Keeping it as is fine as well I just feel the newline looks cleaner.
Attention is currently required from:
- Aryan Krishnan
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
May 8, 2026, 1:25:54 PM (5 days ago) May 8
to Lei Zhang, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan and Lei Zhang
Tom Sepez added 1 comment![]( "Open in Gerrit")
File core/fxge/renderdevicedriver_iface.h
Line 82, Patchset 3 (Latest):
virtual int GetHorzSize() const;Tom Sepez . unresolved
should these be pure virtuals?
Related details
Attention is currently required from:
- Aryan Krishnan
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
May 8, 2026, 1:27:52 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan and Tom Sepez
Lei Zhang added 1 comment![]( "Open in Gerrit")
File core/fxge/renderdevicedriver_iface.h
Line 82, Patchset 3 (Latest):
virtual int GetHorzSize() const;Tom Sepez . unresolved
should these be pure virtuals?
Lei Zhang
Just eyeballing, but I think that means the AGG and Skia drivers have to implement them for Windows.
Related details
Attention is currently required from:
- Aryan Krishnan
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
May 8, 2026, 1:28:41 PM (5 days ago) May 8
to Lei Zhang, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan and Lei Zhang
Tom Sepez voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Sepez
| Code-Review | +1 |
1 comment
File core/fxge/renderdevicedriver_iface.h
Line 82, Patchset 3 (Latest):
virtual int GetHorzSize() const;Tom Sepez . resolved
Lei Zhangshould these be pure virtuals?
Just eyeballing, but I think that means the AGG and Skia drivers have to implement them for Windows.
Attention is currently required from:
- Aryan Krishnan
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
May 8, 2026, 1:34:49 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Aryan Krishnan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 8, 2026, 2:14:45 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, Aryan Krishnan, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Make CFX_RenderDevice::Get{Horz,Vert}Size() Windows-only
CFX_RenderDevice::GetHorzSize() and GetVertSize() are only useful on
Windows, since only Windows-specific RenderDeviceDriverIface overrides
for these 2 methods return non-zero values. On other platforms, they
only return 0, so the only caller in CPDF_DeviceBuffer can effectively
not call them and get the same result. With these CFX_RenderDevice
marked as Windows-only, also mark the RenderDeviceDriverIface() methods
with the same names as Windows-only. Then slightly simplify
CPDF_DeviceBuffer::CalculateMatrix() as well.Change-Id: I23c5e254d26167f8bddd4467ef676172ed2230b2
Reviewed-by: Tom Sepez <tse...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Files:
- M core/fpdfapi/render/cpdf_devicebuffer.cpp
- M core/fpdfapi/render/cpdf_devicebuffer.h
- M core/fpdfapi/render/cpdf_scaledrenderbuffer.cpp
- M core/fxge/cfx_renderdevice.cpp
- M core/fxge/cfx_renderdevice.h
- M core/fxge/renderdevicedriver_iface.cpp
- M core/fxge/renderdevicedriver_iface.h
Change size: M
Delta: 7 files changed, 25 insertions(+), 29 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tom Sepez
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages