Make CFX_Face::GetData() take date directly from CFX_Face member. [pdfium : main]

0 views
Skip to first unread message

Tom Sepez (Gerrit)

unread,
6:21 PM (4 hours ago) 6:21 PM
to Pdfium LUCI CQ, pdfium-...@googlegroups.com

Tom Sepez added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Tom Sepez . resolved

PS3 passes the tests with PDF_ENABLE_SKIA_TYPEFACE_CHECKS enabled, PS4 resets this.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I2b5f0b36d504a3f687777432e953b5d176848362
Gerrit-Change-Number: 145032
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Mar 2026 22:21:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
6:21 PM (4 hours ago) 6:21 PM
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

Tom Sepez voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I2b5f0b36d504a3f687777432e953b5d176848362
Gerrit-Change-Number: 145032
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Mar 2026 22:21:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
6:30 PM (4 hours ago) 6:30 PM
to Tom Sepez, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Code-Review+1

1 comment

Commit Message
Line 7, Patchset 4 (Latest):Make CFX_Face::GetData() take date directly from CFX_Face member.
Lei Zhang . unresolved

typo: data

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I2b5f0b36d504a3f687777432e953b5d176848362
Gerrit-Change-Number: 145032
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Mar 2026 22:30:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages