Make CFX_Face::GetData() take date directly from CFX_Face member. [pdfium : main]

0 views

Skip to first unread message

Tom Sepez (Gerrit)

unread,

6:21 PM (4 hours ago) 6:21 PM

to Pdfium LUCI CQ, pdfium-...@googlegroups.com

Tom Sepez added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Tom Sepez . resolved

PS3 passes the tests with PDF_ENABLE_SKIA_TYPEFACE_CHECKS enabled, PS4 resets this.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tom Sepez (Gerrit)

unread,

6:21 PM (4 hours ago) 6:21 PM

to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com

Attention needed from Lei Zhang

Tom Sepez voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

6:30 PM (4 hours ago) 6:30 PM

to Tom Sepez, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com

Attention needed from Tom Sepez

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Code-Review

1 comment

Commit Message

Line 7, Patchset 4 (Latest):Make CFX_Face::GetData() take date directly from CFX_Face member.

Lei Zhang . unresolved

typo: data

Open in Gerrit

Related details

Attention is currently required from:

Tom Sepez

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages