Clarify C++ standard in .clang-format [pdfium : main]

0 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
May 5, 2026, 11:30:58 PM (8 days ago) May 5
to Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

Victor Vianna voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I4860f4908a59b651b10e2fd3835e24f9ca72a232
Gerrit-Change-Number: 147250
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Wed, 06 May 2026 03:30:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
May 5, 2026, 11:37:23 PM (8 days ago) May 5
to Victor Vianna, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Victor Vianna

Lei Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I4860f4908a59b651b10e2fd3835e24f9ca72a232
Gerrit-Change-Number: 147250
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Wed, 06 May 2026 03:37:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
May 5, 2026, 11:37:29 PM (8 days ago) May 5
to Victor Vianna, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Victor Vianna

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I4860f4908a59b651b10e2fd3835e24f9ca72a232
Gerrit-Change-Number: 147250
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Wed, 06 May 2026 03:37:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
May 6, 2026, 12:28:28 PM (7 days ago) May 6
to Victor Vianna, pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Victor Vianna

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I4860f4908a59b651b10e2fd3835e24f9ca72a232
Gerrit-Change-Number: 147250
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Wed, 06 May 2026 16:28:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
May 6, 2026, 12:31:24 PM (7 days ago) May 6
to Victor Vianna, Lei Zhang, pdfium-...@googlegroups.com

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Clarify C++ standard in .clang-format

"Cpp11" is not C++11, it's the same as "Latest".
https://github.com/llvm/llvm-project/blob/d4c0c7b38f83fee7d992a2d07dde17cce5fdb9e4/clang/lib/Format/Format.cpp#L546-L547
Change-Id: I4860f4908a59b651b10e2fd3835e24f9ca72a232
Commit-Queue: Lei Zhang <the...@chromium.org>
Auto-Submit: Victor Vianna <victor...@google.com>
Reviewed-by: Lei Zhang <the...@chromium.org>
Files:
  • M .clang-format
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Lei Zhang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I4860f4908a59b651b10e2fd3835e24f9ca72a232
Gerrit-Change-Number: 147250
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages