Fix logic botch in cpdf_nametree.cpp [pdfium : main]
Skip to first unread message
Tom Sepez (Gerrit)
Jun 2, 2026, 2:53:31 PM (2 days ago) Jun 2
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Jun 2, 2026, 3:44:44 PM (2 days ago) Jun 2
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 2, 2026, 4:01:49 PM (2 days ago) Jun 2
to Tom Sepez, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted![]( "Open in Gerrit")
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 2, 2026, 5:30:08 PM (2 days ago) Jun 2
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix logic botch in cpdf_nametree.cpp
Introduced in
https://pdfium-review.googlesource.com/c/pdfium/+/146590
-- Add a better test.
Bug: 519007689
Change-Id: I98b01afc6e05941e3c2a10821cea88e9c275b354
Commit-Queue: Lei Zhang <the...@chromium.org>
Auto-Submit: Tom Sepez <tse...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Files:
- M core/fpdfdoc/cpdf_nametree.cpp
- M core/fpdfdoc/cpdf_nametree_unittest.cpp
Change size: S
Delta: 2 files changed, 35 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages