Fix CFX_GlyphBitmap::GetBitmap() const correctness [pdfium : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Feb 20, 2026, 12:17:23 PM (2 days ago) Feb 20
to Lei Zhang, Tom Sepez, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez

Lei Zhang added 1 comment

File core/fxge/cfx_renderdevice.cpp
Line 208, Patchset 2 (Latest): const CFX_DIBitmap* pGlyph,
Lei Zhang . resolved

OK without the RetainPtr wrapper?

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I65ea18a1d2910b8be6f413d8fd4524ecc738b228
Gerrit-Change-Number: 143454
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 17:17:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages