fxge: Share manual font table parsing and use in Android [pdfium : main]

1 view

Skip to first unread message

Tom Sepez (Gerrit)

unread,

Jun 1, 2026, 2:24:54 PM (3 days ago) Jun 1

to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Attention needed from Lei Zhang

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Jun 1, 2026, 7:36:50 PM (3 days ago) Jun 1

to Tom Sepez, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Attention needed from Tom Sepez

Lei Zhang added 5 comments

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Lei Zhang . unresolved

How about prepending a CL to add FindFontTable() first? There's a lot of moving pieces in this CL and it's a bit hard to keep track of it all.

Commit Message

Line 12, Patchset 13:on FreeType. Following this CL, we can re-shape the fxge code to operate

Lei Zhang . unresolved

go/avoid-we

File core/fxge/android/cfpf_skiafont.cpp

Line 37, Patchset 13: return pdfium::checked_cast<uint32_t>(table_data.size());

Lei Zhang . unresolved

Flip the conditional on line 33 and combine this line with line 34?

File core/fxge/cfx_folderfontinfo.cpp

Line 193, Patchset 13: uint32_t name_tag = CFX_FontMapper::MakeTag('n', 'a', 'm', 'e');

Lei Zhang . unresolved

1) Why make this non-const?
2) Actually, this one can be `SystemFontInfoIface::kTableNAME`.

File core/fxge/fx_font_unittest.cpp

Line 94, Patchset 13: EXPECT_EQ(10u, head_table.size());

Lei Zhang . unresolved

ASSERT_EQ() here and line 101.

Open in Gerrit

Related details

Attention is currently required from:

Tom Sepez

Submit Requirements:

Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages