Avoid bounds checking in CJBig2_GRDProc loops [pdfium : main]
0 views
Skip to first unread message
Lei Zhang (Gerrit)
May 12, 2026, 5:19:49 PM (24 hours ago) May 12
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Lei Zhang . resolved
I tried a bunch of other ways but can't nudge the compiler into avoiding bounds checks. I could restructure all the constants into a struct, but it's a bit more churn.
Related details
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
10:55 AM (6 hours ago) 10:55 AM
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Lei Zhang . resolved
Didn't have the correct build flags / figured out something that could be better.
Related details
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
10:55 AM (6 hours ago) 10:55 AM
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Lei Zhang abandoned this change.
Abandoned
Nope
Lei Zhang abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages