Fold 0035-opj_image_data_free.patch into 0022-jp2_apply_pclr_overflow.patch [pdfium : main]
0 views
Skip to first unread message
Nico Weber (Gerrit)
May 1, 2026, 8:44:31 PM (12 days ago) May 1
to Nico Weber, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Nico Weber voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Weber
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Nico Weber . resolved
(FYI: You have an outdated OOO message in your profile over here.)
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
May 4, 2026, 5:38:46 PM (9 days ago) May 4
to Nico Weber, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Nico Weber
Lei Zhang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
Nico Weber . resolved
(FYI: You have an outdated OOO message in your profile over here.)
Lei Zhang
Thanks. Fixed.
Commit Message
Line 14, Patchset 2 (Latest):
Instread of having one patch add a wrong line and then fixing it up in aLei Zhang . unresolved
typo
Related details
Attention is currently required from:
- Nico Weber
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
May 4, 2026, 7:04:26 PM (9 days ago) May 4
to Nico Weber, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Nico Weber added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Commit Message
Line 14, Patchset 2:
Instread of having one patch add a wrong line and then fixing it up in aLei Zhang . resolved
Nico Webertypo
Done
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
May 5, 2026, 2:29:35 PM (8 days ago) May 5
to Nico Weber, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang and Nico Weber
Nico Weber voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Lei Zhang
- Nico Weber
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
May 5, 2026, 2:30:49 PM (8 days ago) May 5
to Nico Weber, Nico Weber, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Nico Weber voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 5, 2026, 2:32:11 PM (8 days ago) May 5
to Nico Weber, Nico Weber, Lei Zhang, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fold 0035-opj_image_data_free.patch into 0022-jp2_apply_pclr_overflow.patch
Most of the original 0035-opj_image_data_free.patch was upstreamed in
https://github.com/uclouvain/openjpeg/commit/b73ce715. One line wasn't,
because that line was added downstream in
0022-jp2_apply_pclr_overflow.patch.
Instead of having one patch add a wrong line and then fixing it up in a
second patch, get it right in the first patch. See also comment 26 on
the linked bug.
While here, also update README.pdfium to note that
0047-opj_j2k_read_sod.patch is a cherry-pick from upstream.
No behavior change.
Bug: chromium:40088936
Change-Id: I9ec49ef36bd6e4d4c9b8bac7d6a751249618d91d
Reviewed-by: Nico Weber <tha...@google.com>
Commit-Queue: Nico Weber <tha...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Files:
- M third_party/libopenjpeg/0022-jp2_apply_pclr_overflow.patch
- D third_party/libopenjpeg/0035-opj_image_data_free.patch
- M third_party/libopenjpeg/README.pdfium
Change size: S
Delta: 3 files changed, 2 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nico Weber, +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages