Add additional helper functions to fpdf_text_embeddertest.cpp [pdfium : main]

[Aryan Krishnan (Gerrit)]

Aryan Krishnan added 3 comments

File fpdfsdk/fpdf_text_embeddertest.cpp

Line 79, Patchset 1 (Latest):struct CharBoxPositions {

Aryan Krishnan . unresolved

Sides instead of CharBoxPositions (its no longer for just CharBoxes)

Line 322, Patchset 1 (Latest): VerifySides({7.168, 12.808, 178.06, 171.4}, {left, right, top, bottom});

Aryan Krishnan . unresolved

Somewhere along the way I probably swapped bottom, top with top, bottom - now about 12 instances have this...

Line 797, Patchset 1 (Latest): VerifySides({-1.0, -1.0, -1.0, -1.0}, {left, right, top, bottom});

Aryan Krishnan . unresolved

These should be exact (797 and 805)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: I552c0667efdd1175fcc8ae2dbbb4fc3ed9ed316a

Gerrit-Change-Number: 145950

Gerrit-PatchSet: 1

Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>

Gerrit-Comment-Date: Thu, 09 Apr 2026 16:02:26 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Aryan Krishnan (Gerrit)]

Aryan Krishnan added 3 comments

File fpdfsdk/fpdf_text_embeddertest.cpp

Line 79, Patchset 1:struct CharBoxPositions {

Aryan Krishnan . resolved

Sides instead of CharBoxPositions (its no longer for just CharBoxes)

Aryan Krishnan

Done

Line 322, Patchset 1: VerifySides({7.168, 12.808, 178.06, 171.4}, {left, right, top, bottom});

Aryan Krishnan . resolved

Somewhere along the way I probably swapped bottom, top with top, bottom - now about 12 instances have this...

Aryan Krishnan

Done

Line 797, Patchset 1: VerifySides({-1.0, -1.0, -1.0, -1.0}, {left, right, top, bottom});

Aryan Krishnan . resolved

These should be exact (797 and 805)

Aryan Krishnan

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: I552c0667efdd1175fcc8ae2dbbb4fc3ed9ed316a

Gerrit-Change-Number: 145950

Gerrit-PatchSet: 2

Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>

Gerrit-Comment-Date: Thu, 09 Apr 2026 17:31:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Aryan Krishnan <aryankr...@gmail.com>

[Aryan Krishnan (Gerrit)]

Aryan Krishnan voted and added 1 comment

Votes added by Aryan Krishnan

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Aryan Krishnan . resolved

Should work now

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: I552c0667efdd1175fcc8ae2dbbb4fc3ed9ed316a

Gerrit-Change-Number: 145950

Gerrit-PatchSet: 3

Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>

Gerrit-Reviewer: Aryan Krishnan <aryankr...@gmail.com>

Gerrit-Comment-Date: Fri, 10 Apr 2026 04:44:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes