Update PDF 1.7 spec references to ISO 32000-1:2008. [pdfium : main]
0 views
Skip to first unread message
Lei Zhang (Gerrit)
Jun 3, 2026, 10:23:24 PM (18 hours ago) Jun 3
to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan
Lei Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Lei Zhang . resolved
I double checked and corrected a few incorrect changes.
Related details
Attention is currently required from:
- Andy Phan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andy Phan (Gerrit)
11:24 AM (5 hours ago) 11:24 AM
to Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Andy Phan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andy Phan
| Code-Review | +1 |
1 comment
File fpdfsdk/formfiller/cffl_textfield.cpp
Line 23, Patchset 1 (Latest):
enum Alignment {Andy Phan . resolved
Existing, but in the "Q" key description.
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
1:23 PM (3 hours ago) 1:23 PM
to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Commit-Queue | +2 |
1 comment
File fpdfsdk/formfiller/cffl_textfield.cpp
Line 23, Patchset 1 (Latest):
enum Alignment {Andy Phan . resolved
Existing, but in the "Q" key description.
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
1:53 PM (2 hours ago) 1:53 PM
to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Update PDF 1.7 spec references to ISO 32000-1:2008.
Update comments referencing the "PDF 1.7 spec" to point to their
corresponding tables and sections in the ISO 32000-1:2008 specification.
Hopefully nobody will need to open pdf_reference_1-7.pdf anymore after
this.
TAG=agy
CONV=e172d025-7526-4dbc-b51d-9fdabcf46a76
Change-Id: I80544bd4df3829cb9292199e9dac7d223b2377a1
Reviewed-by: Andy Phan <andy...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Files:
- M constants/access_permissions.h
- M constants/annotation_common.h
- M constants/annotation_flags.h
- M constants/form_flags.h
- M constants/page_object.h
- M constants/stream_dict_common.h
- M constants/transparency.h
- M core/fpdfapi/page/cpdf_colorspace.cpp
- M core/fpdfapi/page/cpdf_occontext.cpp
- M core/fpdfapi/page/cpdf_shadingpattern.cpp
- M core/fpdfapi/page/cpdf_shadingpattern.h
- M core/fpdfapi/parser/cpdf_hint_tables.cpp
- M core/fxcrt/fx_number.cpp
- M core/fxcrt/fx_number_unittest.cpp
- M core/fxge/dib/fx_dib.h
- M fpdfsdk/formfiller/cffl_textfield.cpp
Change size: M
Delta: 16 files changed, 28 insertions(+), 28 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andy Phan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages