Remove RenderCapAlphaPath() [pdfium : main]
0 views
Skip to first unread message
Aryan Krishnan (Gerrit)
May 8, 2026, 12:43:19 PM (5 days ago) May 8
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
Commit Message
Line 10, Patchset 1 (Latest):
other RenderCapAlphaPath() methods are all doing work for nothing.Aryan Krishnan . unresolved
Nit: Newline between change ID and text.
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
May 8, 2026, 12:46:45 PM (5 days ago) May 8
to Lei Zhang, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
May 8, 2026, 1:01:48 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
Commit Message
Line 10, Patchset 1:
other RenderCapAlphaPath() methods are all doing work for nothing.Aryan Krishnan . resolved
Nit: Newline between change ID and text.
Aryan Krishnan
Marked as resolved.
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
May 8, 2026, 1:23:00 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 8, 2026, 1:25:12 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, Aryan Krishnan, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Remove RenderCapAlphaPath()
CFX_RenderDevice::RenderCapAlphaPath() has no callers, so it and all the
other RenderCapAlphaPath() methods are all doing work for nothing.
Change-Id: Ibe49e12617c96c2ebf3b51981425656c81f47bb7
Reviewed-by: Tom Sepez <tse...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Files:
- M core/fxge/agg/cfx_agg_devicedriver.cpp
- M core/fxge/agg/cfx_agg_devicedriver.h
- M core/fxge/cfx_renderdevice.cpp
- M core/fxge/cfx_renderdevice.h
- M core/fxge/renderdevicedriver_iface.cpp
- M core/fxge/renderdevicedriver_iface.h
- M core/fxge/skia/fx_skia_device.cpp
- M core/fxge/skia/fx_skia_device.h
- M core/fxge/win32/cgdi_device_driver.cpp
- M core/fxge/win32/cgdi_device_driver.h
- M core/fxge/win32/cgdi_display_driver.cpp
Change size: S
Delta: 11 files changed, 0 insertions(+), 26 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tom Sepez
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages