Limit the maximum destination image size in CStretchEngine [pdfium : main]

0 views

Skip to first unread message

Tom Sepez (Gerrit)

unread,

Apr 8, 2026, 5:13:47 PM (3 days ago) Apr 8

to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com

Attention needed from Lei Zhang

Tom Sepez voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Apr 8, 2026, 5:48:25 PM (3 days ago) Apr 8

to Lei Zhang, Tom Sepez, Pdfium LUCI CQ, pdfium-...@googlegroups.com

Lei Zhang voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Pdfium LUCI CQ (Gerrit)

unread,

Apr 8, 2026, 5:49:43 PM (3 days ago) Apr 8

to Lei Zhang, Tom Sepez, pdfium-...@googlegroups.com

Pdfium LUCI CQ submitted the change

Change information

Commit message:

Limit the maximum destination image size in CStretchEngine

Pick a sufficiently large, though arbitrary limit for CStretchEngine's
destination image width/height. This avoids undefined behavior if a
dimension is INT_MIN. Make this check publicly available as
CStretchEngine::IsValidDestinationDimension() and use it in
CFX_SkiaDeviceDriver::StartDIBitsSkia() as well.

Bug: 499330946

Change-Id: Id468fb2b7a6185a9b26745966da1caf641ce249f

Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/145931

Commit-Queue: Lei Zhang <the...@chromium.org>

Reviewed-by: Tom Sepez <tse...@chromium.org>

Files:

M core/fxge/dib/cstretchengine.cpp
M core/fxge/dib/cstretchengine.h
M core/fxge/skia/fx_skia_device.cpp

Change size: S

Delta: 3 files changed, 16 insertions(+), 3 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Tom Sepez

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages