Pre-calculate line spans in CJBig2_Image [pdfium : main]
0 views
Skip to first unread message
Lei Zhang (Gerrit)
Jan 30, 2026, 1:06:32 PMJan 30
to Lei Zhang, Tom Sepez, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang added 1 comment![]( "Open in Gerrit")
File core/fxcodec/jbig2/JBig2_Image.cpp
Line 272, Patchset 1:
if (width_ <= 0 || height_ <= 0 || !data_) {Lei Zhang . resolved
Actually, this check isn't needed. Removing.
Related details
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Jan 30, 2026, 1:14:21 PMJan 30
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Tom Sepez . resolved
meh. Can we ponder if there is a better way 'round this?
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jan 30, 2026, 1:22:02 PMJan 30
to Lei Zhang, Tom Sepez, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Tom Sepez . resolved
meh. Can we ponder if there is a better way 'round this?
Lei Zhang
I tried caching the `GetLineOffset() + stride_` value if the next GetLine() call is for line `y + 1`, but that didn't actually seem to help with performance. But I didn't try very hard, so maybe that implementation had a bug.
My other guess is many places do consecutive access, but other places do random row access.
I'll have to check again...
Related details
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
May 11, 2026, 8:26:52 PM (2 days ago) May 11
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Lei Zhang abandoned this change.
Lei Zhang abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages