Support visual rendering for pure RTL text [pdfium : main]

0 views

Skip to first unread message

Lei Zhang (Gerrit)

unread,

Jun 23, 2026, 7:17:08 PM (2 days ago) Jun 23

to Seung Hyun Jin, Lei Zhang, April Kallmeyer, pdfium-...@googlegroups.com

Attention needed from Seung Hyun Jin

Lei Zhang added 2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Lei Zhang . resolved

Thanks for splitting up your CL more, but usually it's better to send CLs in a chain out for review in order. It's still "your turn" on the parent CL.

Commit Message

Line 9, Patchset 2 (Latest):Prevent `cpdf_generateap` and `cpdfsdk_appstream` from batching RTL

Lei Zhang . unresolved

Usually backticks wrap references to code, so readers can tell it's not a normal word. Whereas filenames, e.g. foo.cpp or bar.py, are sufficiently distinct that readers can tell what they are.

Open in Gerrit

Related details

Attention is currently required from:

Seung Hyun Jin

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Seung Hyun Jin (Gerrit)

unread,

Jun 23, 2026, 7:30:59 PM (2 days ago) Jun 23

to Lei Zhang, April Kallmeyer, pdfium-...@googlegroups.com

Attention needed from Lei Zhang

Seung Hyun Jin added 2 comments

Patchset-level comments

File-level comment, Patchset 2:

Lei Zhang . resolved

Thanks for splitting up your CL more, but usually it's better to send CLs in a chain out for review in order. It's still "your turn" on the parent CL.

Seung Hyun Jin

Yes, sorry, I meant to only add you as reviewer and not pass the potato to you, just wanted you to see that I was splitting up the CL regarding the visual rendering aspect

Commit Message

Line 9, Patchset 2:Prevent `cpdf_generateap` and `cpdfsdk_appstream` from batching RTL

Lei Zhang . resolved

Usually backticks wrap references to code, so readers can tell it's not a normal word. Whereas filenames, e.g. foo.cpp or bar.py, are sufficiently distinct that readers can tell what they are.

Seung Hyun Jin

Done

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages