Remove more CFX_RenderDevice getters [pdfium : main]
0 views
Skip to first unread message
Aryan Krishnan (Gerrit)
May 8, 2026, 12:43:01 PM (5 days ago) May 8
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
Commit Message
Line 10, Patchset 1 (Latest):
used interanlly in CFX_RenderDevice. For RenderCapPremultipliedAlpha(),Aryan Krishnan . unresolved
Internally
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
May 8, 2026, 12:48:29 PM (5 days ago) May 8
to Lei Zhang, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
May 8, 2026, 12:50:42 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
Commit Message
Line 10, Patchset 1:
used interanlly in CFX_RenderDevice. For RenderCapPremultipliedAlpha(),Aryan Krishnan . resolved
Aryan KrishnanInternally
Resolving
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
May 8, 2026, 1:23:14 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 8, 2026, 1:25:50 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, Aryan Krishnan, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove more CFX_RenderDevice getters
Most of these getters have no callers, though the values they return are
used internally in CFX_RenderDevice. For RenderCapPremultipliedAlpha(),
replace it with CanUseARGBPremul(), which is effectively the same.
Change-Id: I67d48c9dd2f2bfc7ade72a8707d610be306a5d8f
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Tom Sepez <tse...@chromium.org>
Files:
- M core/fpdfapi/render/cpdf_renderstatus.cpp
- M core/fxge/cfx_renderdevice.cpp
- M core/fxge/cfx_renderdevice.h
Change size: S
Delta: 3 files changed, 1 insertion(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tom Sepez
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages