Remove more CFX_RenderDevice getters [pdfium : main]

0 views
Skip to first unread message

Aryan Krishnan (Gerrit)

unread,
May 8, 2026, 12:43:01 PM (5 days ago) May 8
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

Aryan Krishnan added 1 comment

Commit Message
Line 10, Patchset 1 (Latest):used interanlly in CFX_RenderDevice. For RenderCapPremultipliedAlpha(),
Aryan Krishnan . unresolved

Internally

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I67d48c9dd2f2bfc7ade72a8707d610be306a5d8f
Gerrit-Change-Number: 147350
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Fri, 08 May 2026 16:42:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
May 8, 2026, 12:48:29 PM (5 days ago) May 8
to Lei Zhang, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

Tom Sepez voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I67d48c9dd2f2bfc7ade72a8707d610be306a5d8f
Gerrit-Change-Number: 147350
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Fri, 08 May 2026 16:48:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Aryan Krishnan (Gerrit)

unread,
May 8, 2026, 12:50:42 PM (5 days ago) May 8
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

Aryan Krishnan added 1 comment

Commit Message
Line 10, Patchset 1:used interanlly in CFX_RenderDevice. For RenderCapPremultipliedAlpha(),
Aryan Krishnan . resolved

Internally

Aryan Krishnan

Resolving

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: I67d48c9dd2f2bfc7ade72a8707d610be306a5d8f
    Gerrit-Change-Number: 147350
    Gerrit-PatchSet: 2
    Gerrit-Owner: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Attention: Lei Zhang <the...@chromium.org>
    Gerrit-Comment-Date: Fri, 08 May 2026 16:50:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Aryan Krishnan <aryankr...@gmail.com>
    satisfied_requirement
    open
    diffy

    Lei Zhang (Gerrit)

    unread,
    May 8, 2026, 1:23:14 PM (5 days ago) May 8
    to Lei Zhang, Tom Sepez, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

    Lei Zhang voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: I67d48c9dd2f2bfc7ade72a8707d610be306a5d8f
    Gerrit-Change-Number: 147350
    Gerrit-PatchSet: 2
    Gerrit-Owner: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Comment-Date: Fri, 08 May 2026 17:23:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

    unread,
    May 8, 2026, 1:25:50 PM (5 days ago) May 8
    to Lei Zhang, Tom Sepez, Aryan Krishnan, pdfium-...@googlegroups.com

    pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

    Change information

    Commit message:
    Remove more CFX_RenderDevice getters

    Most of these getters have no callers, though the values they return are
    used internally in CFX_RenderDevice. For RenderCapPremultipliedAlpha(),
    replace it with CanUseARGBPremul(), which is effectively the same.
    Change-Id: I67d48c9dd2f2bfc7ade72a8707d610be306a5d8f
    Commit-Queue: Lei Zhang <the...@chromium.org>
    Reviewed-by: Tom Sepez <tse...@chromium.org>
    Files:
    • M core/fpdfapi/render/cpdf_renderstatus.cpp
    • M core/fxge/cfx_renderdevice.cpp
    • M core/fxge/cfx_renderdevice.h
    Change size: S
    Delta: 3 files changed, 1 insertion(+), 12 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Tom Sepez
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: I67d48c9dd2f2bfc7ade72a8707d610be306a5d8f
    Gerrit-Change-Number: 147350
    Gerrit-PatchSet: 3
    Gerrit-Owner: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages