Rename CFX_StandardFont::StandardFont to CFX_StandardFont::Index. [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Jun 24, 2026, 8:35:02 PM (6 hours ago) Jun 24
to Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 24, 2026, 8:44:24 PM (6 hours ago) Jun 24
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
Commit Message
Line 9, Patchset 3 (Latest):
The old name is both redundant and not meaningful.Lei Zhang . resolved
Looks like a double standard to me.
Related details
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Jun 24, 2026, 8:45:47 PM (6 hours ago) Jun 24
to Lei Zhang, pdfium-...@googlegroups.com
Tom Sepez added 1 comment![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 3 (Latest):
The old name is both redundant and not meaningful.Lei Zhang . resolved
Looks like a double standard to me.
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Jun 24, 2026, 9:13:52 PM (5 hours ago) Jun 24
to Lei Zhang, pdfium-...@googlegroups.com
Tom Sepez voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 24, 2026, 9:46:39 PM (5 hours ago) Jun 24
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Rename CFX_StandardFont::StandardFont to CFX_StandardFont::Index.
The old name is both redundant and not meaningful.
Change-Id: I59c622030bfdfd5012766ed69fa97b010ef3c78c
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Files:
- M core/fpdfapi/font/cpdf_font.cpp
- M core/fpdfapi/font/cpdf_fontglobals.cpp
- M core/fpdfapi/font/cpdf_fontglobals.h
- M core/fpdfapi/font/cpdf_stockfontarray.cpp
- M core/fpdfapi/font/cpdf_stockfontarray.h
- M core/fpdfapi/font/cpdf_type1font.h
- M core/fpdfapi/page/cpdf_docpagedata.cpp
- M core/fxge/cfx_fontmapper.cpp
- M core/fxge/cfx_standardfont.cpp
- M core/fxge/cfx_standardfont.h
Change size: M
Delta: 10 files changed, 30 insertions(+), 33 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages