Upgrade to lcms 2.19 [pdfium : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
May 11, 2026, 7:42:49 PM (2 days ago) May 11
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Tom Sepez

Lei Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 15 (Latest):
Lei Zhang . resolved

See diffs between patchsets for progression.

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I1d0c895d63d4b28fa9d008e83a89a7ef4aab9379
Gerrit-Change-Number: 147470
Gerrit-PatchSet: 15
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Mon, 11 May 2026 23:42:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
May 12, 2026, 2:23:06 PM (yesterday) May 12
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

Tom Sepez voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I1d0c895d63d4b28fa9d008e83a89a7ef4aab9379
Gerrit-Change-Number: 147470
Gerrit-PatchSet: 15
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Tue, 12 May 2026 18:23:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
May 12, 2026, 2:28:47 PM (yesterday) May 12
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I1d0c895d63d4b28fa9d008e83a89a7ef4aab9379
Gerrit-Change-Number: 147470
Gerrit-PatchSet: 16
Gerrit-Comment-Date: Tue, 12 May 2026 18:28:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
May 12, 2026, 2:29:41 PM (yesterday) May 12
to Lei Zhang, Tom Sepez, pdfium-...@googlegroups.com

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Unreviewed changes

15 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Upgrade to lcms 2.19

Get the latest security fixes.
Bug: 512405083
Change-Id: I1d0c895d63d4b28fa9d008e83a89a7ef4aab9379
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Tom Sepez <tse...@chromium.org>
Files:
  • M third_party/lcms/0000-cmserr-changes.patch
  • D third_party/lcms/0030-const-data.patch
  • D third_party/lcms/0034-dead-code.patch
  • D third_party/lcms/0036-cubesize-overflow.patch
  • M third_party/lcms/0037-theoretical-overflow.patch
  • M third_party/lcms/README.pdfium
  • M third_party/lcms/include/lcms2.h
  • M third_party/lcms/include/lcms2_plugin.h
  • M third_party/lcms/src/cmsalpha.c
  • M third_party/lcms/src/cmscam02.c
  • M third_party/lcms/src/cmscgats.c
  • M third_party/lcms/src/cmscnvrt.c
  • M third_party/lcms/src/cmsgamma.c
  • M third_party/lcms/src/cmsgmt.c
  • M third_party/lcms/src/cmshalf.c
  • M third_party/lcms/src/cmsintrp.c
  • M third_party/lcms/src/cmsio0.c
  • M third_party/lcms/src/cmsio1.c
  • M third_party/lcms/src/cmslut.c
  • M third_party/lcms/src/cmsmd5.c
  • M third_party/lcms/src/cmsmtrx.c
  • M third_party/lcms/src/cmsnamed.c
  • M third_party/lcms/src/cmsopt.c
  • M third_party/lcms/src/cmspack.c
  • M third_party/lcms/src/cmspcs.c
  • M third_party/lcms/src/cmsplugin.c
  • M third_party/lcms/src/cmsps2.c
  • M third_party/lcms/src/cmssamp.c
  • M third_party/lcms/src/cmssm.c
  • M third_party/lcms/src/cmstypes.c
  • M third_party/lcms/src/cmsvirt.c
  • M third_party/lcms/src/cmswtpnt.c
  • M third_party/lcms/src/cmsxform.c
  • M third_party/lcms/src/lcms2_internal.h
Change size: XL
Delta: 34 files changed, 2871 insertions(+), 900 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Tom Sepez
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I1d0c895d63d4b28fa9d008e83a89a7ef4aab9379
Gerrit-Change-Number: 147470
Gerrit-PatchSet: 17
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages