Restore `desc_` member to CFX_Face [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
1:26 PM (8 hours ago) 1:26 PM
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
2:23 PM (7 hours ago) 2:23 PM
to Tom Sepez, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
Commit Message
Line 16, Patchset 7 (Latest):
Bug: b/493114644Lei Zhang . unresolved
No prefix needed. It'll just redirect.
Related details
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
2:24 PM (7 hours ago) 2:24 PM
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Tom Sepez added 1 comment![]( "Open in Gerrit")
Commit Message
No prefix needed. It'll just redirect.
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
2:26 PM (7 hours ago) 2:26 PM
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Tom Sepez voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
2:28 PM (7 hours ago) 2:28 PM
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
7 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Restore `desc_` member to CFX_Face
Fix non-sharing of font data via font cache entries. The change at
ab5543c60293413b726aba668af1f4c3546b4b27 likely caused duplicate
storage to be allocated because the cache entries didn't live long
enough to allow them to provide an index into existing storage.
-- rename members while at it to better describe the purpose.
Bug: 493114644
Change-Id: I5b2fa43a111ee34695a1935c67900d70a7c5e4f9
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Files:
- M core/fxge/android/cfpf_skiafontmgr.cpp
- M core/fxge/cfx_face.cpp
- M core/fxge/cfx_face.h
- M core/fxge/cfx_font.cpp
- M core/fxge/cfx_fontmapper.cpp
- M xfa/fgas/font/cfgas_fontmgr.cpp
Change size: M
Delta: 6 files changed, 40 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages