Cherry-pick openjpeg changes to speed up jpeg2000 decoding on arm [pdfium : main]

0 views
Skip to first unread message

Nico Weber (Gerrit)

unread,
May 5, 2026, 3:14:20 PM (8 days ago) May 5
to Nico Weber, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

Nico Weber voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ie55ffafb8ab9f5cb690de094e6236444b9b772b1
Gerrit-Change-Number: 147230
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Tue, 05 May 2026 19:14:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
May 5, 2026, 3:52:40 PM (8 days ago) May 5
to Nico Weber, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Nico Weber

Lei Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nico Weber
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ie55ffafb8ab9f5cb690de094e6236444b9b772b1
Gerrit-Change-Number: 147230
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Tue, 05 May 2026 19:52:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nico Weber (Gerrit)

unread,
May 5, 2026, 3:54:33 PM (8 days ago) May 5
to Nico Weber, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Nico Weber

Nico Weber voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nico Weber
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie55ffafb8ab9f5cb690de094e6236444b9b772b1
    Gerrit-Change-Number: 147230
    Gerrit-PatchSet: 5
    Gerrit-Owner: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@google.com>
    Gerrit-Comment-Date: Tue, 05 May 2026 19:54:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Nico Weber (Gerrit)

    unread,
    May 5, 2026, 3:54:43 PM (8 days ago) May 5
    to Nico Weber, Nico Weber, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

    Nico Weber voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie55ffafb8ab9f5cb690de094e6236444b9b772b1
    Gerrit-Change-Number: 147230
    Gerrit-PatchSet: 5
    Gerrit-Owner: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@google.com>
    Gerrit-Comment-Date: Tue, 05 May 2026 19:54:42 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

    unread,
    May 5, 2026, 3:56:51 PM (8 days ago) May 5
    to Nico Weber, Nico Weber, Lei Zhang, pdfium-...@googlegroups.com

    pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

    Change information

    Commit message:
    Cherry-pick openjpeg changes to speed up jpeg2000 decoding on arm

    On my system (Apple M4 Max), takes

    pdfium_test --pages=1-50 disquisitionesa00gaus.pdf

    from 1.637 s ± 0.008 s to 1.477 s ± 0.007 s (measured using hyperfine).

    File available here: https://archive.org/details/disquisitionesa00gaus

    No intended behavior change.

    While here, update README.pdfium to note that another of our downstream
    patches has been upstreamed.
    Bug: none
    Change-Id: Ie55ffafb8ab9f5cb690de094e6236444b9b772b1
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Reviewed-by: Nico Weber <tha...@google.com>
    Commit-Queue: Nico Weber <tha...@chromium.org>
    Files:
    • A third_party/libopenjpeg/0048-dwt_neon_9-7_idwt.patch
    • A third_party/libopenjpeg/0049-dwt_neon_5-3_idwt.patch
    • M third_party/libopenjpeg/README.pdfium
    • M third_party/libopenjpeg/dwt.c
    Change size: L
    Delta: 4 files changed, 327 insertions(+), 15 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Nico Weber, +1 by Lei Zhang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie55ffafb8ab9f5cb690de094e6236444b9b772b1
    Gerrit-Change-Number: 147230
    Gerrit-PatchSet: 6
    Gerrit-Owner: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages